From nobody Tue Feb 28 10:14:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQtWR5l6Zz3vGgX; Tue, 28 Feb 2023 10:14:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQtWR2gCBz3qg2; Tue, 28 Feb 2023 10:14:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677579251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FTEZZ0ADHhqgEg5ZBkq9zf4sd0sVeWq2y2tFonykvWc=; b=R8bI67+XWpHgKb3E8cmgDR2yQAfIYC9UkyO0WkXIB+Ey7AOHvBrCtPBrR7wz6jTdI+FjGV OzagyhlCDYk5oJgLugzKyZ2OmTwGUrNSNHJzDzDqIF+jZcDdHsaQCkh6qJcFxvg7p2s/7X 4s3mBts8nhH1EOboY8XiuambVcV8ZK61BebGQxIszEUXUCG551j9l3+NpZHGvFBSsCUE/R SiVTbHf/UuMXhQNEzOyF/w0JV6koZLzBBKKiRpaMgBGyCGO1sJ1twGFMLxl1cNCCqPtM4m 65aVDWJLeLEJA9Y8Mmo+J7pZJLW2JknaAqZ9yAR6legS5EwktRnEW/1Z578Z4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677579251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FTEZZ0ADHhqgEg5ZBkq9zf4sd0sVeWq2y2tFonykvWc=; b=I8mDyRmd0nOLbxEjDt5oIpdYHI7kAbqBLoHCFt2/gefZV4wcTDgTaLchuZBU/q+S/1LXWa PoSbZRd+PfGenDQ716++wff3UwZZe3ZjLMX86fVIIgTuOKd6XGsR+nq4OHbGA3c1L8s2CA nXvBlzlHmnDfR+dfhtXulRlBmSwerKRFNJInaDNiikjGzfovc0vsRZfisB60/5wEKoy4b1 ei+O3Jndy1HdE2BBtPjfbtga0hWp3Pzr5HAGzXNxqu/lXVD+g0z+2vuJbPQXhvmQtunYV/ s3BwZ2x7YDHxdsbc/UgkeDtwuRZ2p0p7oyDp+qSBgRYlRUNlHg/VXODUDslLjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677579251; a=rsa-sha256; cv=none; b=D3dT1iHz0wtIkq1UN9hAHQqz7BxyZnaJg62gwdB6j8qT1SbCXFGEYYnMsIS8+VDO5EiF3A lKql7GlVwKgZaaWqD1ZUYz8mwwvwguJmiehRGOYc2a0wpjQ6WxjK+Fd14nUAwKyjU6cWuD U54QAtCmBlclpHp4Pqzgl8d5R3Vsg7QvCYyq7+q5hyCXg35EemlzACrCOWsZGtZkADkNeS B45BX4Z1/t68dM8uPQki3XPgBEAuacy9T1LJ1RR/9SlM/5SKVzKw2/EWFF34q9j/rKTUhi ymLoGsq6zf6tydgBeLYq1uROdjPBaWtvr+VOXJjedMRZ8xiKPnpdo1VVbzdQrQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PQtWR1mrbz13Rb; Tue, 28 Feb 2023 10:14:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 31SAEB5j013772; Tue, 28 Feb 2023 10:14:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 31SAEBeu013771; Tue, 28 Feb 2023 10:14:11 GMT (envelope-from git) Date: Tue, 28 Feb 2023 10:14:11 GMT Message-Id: <202302281014.31SAEBeu013771@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: =?utf-8?Q?Corvin=20K=C3=B6hne?= Subject: git: 2c1cbd083696 - stable/13 - bhyve: maintain a list of acpi devices List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 2c1cbd083696086aeb9f0d75ddcfbb04183de081 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=2c1cbd083696086aeb9f0d75ddcfbb04183de081 commit 2c1cbd083696086aeb9f0d75ddcfbb04183de081 Author: Corvin Köhne AuthorDate: 2021-10-07 14:14:31 +0000 Commit: Corvin Köhne CommitDate: 2023-02-28 10:04:34 +0000 bhyve: maintain a list of acpi devices The list is used to generate the dsdt entry for every acpi device. Reviewed by: markj MFC after: 1 week Sponsored by: Beckhoff Automation GmbH & Co. KG Differential Revision: https://reviews.freebsd.org/D3830 (cherry picked from commit fbd045021d9ffdae5e5bb20e1d1890fd4b46498e) --- usr.sbin/bhyve/acpi.c | 29 +++++++++++++++++++++++++++++ usr.sbin/bhyve/acpi.h | 3 +++ usr.sbin/bhyve/acpi_device.c | 6 ++++++ 3 files changed, 38 insertions(+) diff --git a/usr.sbin/bhyve/acpi.c b/usr.sbin/bhyve/acpi.c index bdb0e97076ad..84a54cc485c5 100644 --- a/usr.sbin/bhyve/acpi.c +++ b/usr.sbin/bhyve/acpi.c @@ -106,6 +106,30 @@ struct basl_fio { #define EFFLUSH(x) \ if (fflush(x) != 0) goto err_exit; +/* + * A list for additional ACPI devices like a TPM. + */ +struct acpi_device_list_entry { + SLIST_ENTRY(acpi_device_list_entry) chain; + const struct acpi_device *dev; +}; +static SLIST_HEAD(acpi_device_list, + acpi_device_list_entry) acpi_devices = SLIST_HEAD_INITIALIZER(acpi_devices); + +int +acpi_tables_add_device(const struct acpi_device *const dev) +{ + struct acpi_device_list_entry *const entry = calloc(1, sizeof(*entry)); + if (entry == NULL) { + return (ENOMEM); + } + + entry->dev = dev; + SLIST_INSERT_HEAD(&acpi_devices, entry, chain); + + return (0); +} + /* * Helper routines for writing to the DSDT from other modules. */ @@ -219,6 +243,11 @@ basl_fwrite_dsdt(FILE *fp) vmgenc_write_dsdt(); + const struct acpi_device_list_entry *entry; + SLIST_FOREACH(entry, &acpi_devices, chain) { + acpi_device_write_dsdt(entry->dev); + } + dsdt_line("}"); if (dsdt_error != 0) diff --git a/usr.sbin/bhyve/acpi.h b/usr.sbin/bhyve/acpi.h index 50e5337f332a..98479913732c 100644 --- a/usr.sbin/bhyve/acpi.h +++ b/usr.sbin/bhyve/acpi.h @@ -31,6 +31,8 @@ #ifndef _ACPI_H_ #define _ACPI_H_ +#include "acpi_device.h" + #define SCI_INT 9 #define SMI_CMD 0xb2 @@ -55,6 +57,7 @@ struct vmctx; int acpi_build(struct vmctx *ctx, int ncpu); void acpi_raise_gpe(struct vmctx *ctx, unsigned bit); +int acpi_tables_add_device(const struct acpi_device *const dev); void dsdt_line(const char *fmt, ...); void dsdt_fixed_ioport(uint16_t iobase, uint16_t length); void dsdt_fixed_irq(uint8_t irq); diff --git a/usr.sbin/bhyve/acpi_device.c b/usr.sbin/bhyve/acpi_device.c index 10259006c619..047d411deec2 100644 --- a/usr.sbin/bhyve/acpi_device.c +++ b/usr.sbin/bhyve/acpi_device.c @@ -68,6 +68,12 @@ acpi_device_create(struct acpi_device **const new_dev, return (ENOMEM); } + const int error = acpi_tables_add_device(dev); + if (error) { + acpi_device_destroy(dev); + return (error); + } + *new_dev = dev; return (0);