Date: Sun, 08 Jul 2018 16:36:47 -0400 From: Eric McCorkle <eric@metricspace.net> To: Ian Lepore <ian@freebsd.org>, Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: Warner Losh <imp@bsdimp.com>, Tommi Pernila <tommi.pernila@iki.fi>, "[ScaleEngine] Allan Jude" <allan.jude@scaleengine.com>, freebsd-current <freebsd-current@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: GELI with UEFI supporting Boot Environments goes to HEAD when? Message-ID: <8AFC01EE-A37A-4D89-9A67-8707AA3184DD@metricspace.net> In-Reply-To: <1531078307.1336.22.camel@freebsd.org> References: <CABHD1wRyrmXp5R_ViERa-MnJnVKN-U551SWt%2Behm6r%2B3viydxg@mail.gmail.com> <0e75a2ba-9a59-8301-a678-68a822025bd6@metricspace.net> <CABHD1wS-RoxP5fsCYgH61BsPsad_OPC4FZSUCUi6EfsWyXRzQA@mail.gmail.com> <9df63df2-9d61-4106-f360-347411869b41@metricspace.net> <f17bbb44-6735-e252-ba75-bd0b4f685d9d@metricspace.net> <CABHD1wRu_C4dPvzt%2BxMsYYYjFNJ1%2B78ne4cLsuCxr=YrN%2BhfFA@mail.gmail.com> <CANCZdfrkW1yteAixk44DetDe=uetVtvxM9-M7K5FioxeLseHJw@mail.gmail.com> <D667242D-ACB8-42E4-85B8-308702C15360@metricspace.net> <CAPQ4fftB27Y63yvk9zqEE3q4-MShHOYdwM7aD=c%2BXKzrs%2BZoMw@mail.gmail.com> <CANCZdfqZ1qr0Z7eiby6Kvwop_-%2B3_VZ0hFnCfo7Hm1NN9UbaUA@mail.gmail.com> <c0c57711-055a-5d0d-796e-f7acce4be3b4@metricspace.net> <CANCZdfpH4z8yhzD_pyJDPy0276FxqQ%2BpEWcp3HiPe-qhNnrYCw@mail.gmail.com> <5ba11024-e99b-86e1-48b7-125fb80b4001@metricspace.net> <CAPQ4fftg_8DRmHhsrt3k4660GyiXGQ%2BQe%2B-%2BOpfitVU5i-jTkA@mail.gmail.com> <1531078307.1336.22.camel@freebsd.org>
index | next in thread | previous in thread | raw e-mail
I intend to endorse this patch over my own once I'm able to test it out on my test images. My approach is highly EFI-specific, and it made sense to do it that way when boot1.efi was still a thing. The architecture agnostic method makes more sense now that it's gone. On July 8, 2018 3:31:47 PM EDT, Ian Lepore <ian@freebsd.org> wrote: >On Sun, 2018-07-08 at 21:08 +0200, Oliver Pinter wrote: >> Hi! >> >> Have you or Warner any update on this code? >> >> On Thursday, April 12, 2018, Eric McCorkle <eric@metricspace.net> >> wrote: >> > >Are you aware of https://reviews.freebsd.org/D15743 ? > >That's my changes to add geli support to loader(8) in an architecture- >agnostic way, so that "it just works" for all platforms and flavors of >loader. It has been succesfully tested on armv6/7 (ubldr) and on x86 >using qemu. The x86 tests cover ufs and zfs, legacy bios and uefi. The >only variations that aren't tested yet are the uefi flavors, because >the current rootgen.sh script for assembling test images is still using >boot1.efi and I don't know enough about efi myself to update the script >to make it assemble images the new way Warner envisions. > >-- Ian > >> > >> > I'm in the middle of moving to a new apartment right now. It's >> > going to >> > be a bit before I can get to this. >> > >> > On 04/11/2018 20:31, Warner Losh wrote: >> > > >> > > OK. I've pushed in the main part of it. The additional work I >> > > have >> > > shouldn't affect any of this stuff. I was going to look at what >> > > part(s) >> > > of your open reviewed needed to be redone tomorrow and send you >> > > feedback, but if you wanted to get a start before then, I'm happy >> > > to >> > > answer questions. All the rest of my work is going to be >> > > selecting the >> > > root partition when we're told to us a specific partition, so >> > > will be >> > > very constrained. >> > > >> > > Warner >> > > >> > > On Wed, Apr 11, 2018 at 6:02 PM, Eric McCorkle <eric@metricspace. >> > > net >> > > <mailto:eric@metricspace.net>> wrote: >> > > >> > > I think the thing to do at this point is to wait for the >> > > current >> > work on >> > > >> > > loader.efi to land, then adapt my patches to apply against >> > > that work. >> > > >> > > On 04/11/2018 15:06, Warner Losh wrote: >> > > > Still reviewing the code. I'm worried it's too i386 >> > > specific and it >> > > > conflicts with some work I'm doing. I'll have a list of >> > > actionable >> > > > critiques this week. >> > > > >> > > > Warner >> > > > >> > > > On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter >> > > > <oliver.pinter@hardenedbsd.org >> > > <mailto:oliver.pinter@hardenedbsd.org> >> > > <mailto:oliver.pinter@hardenedbsd.org >> > > <mailto:oliver.pinter@hardenedbsd.org>>> >> > > > wrote: >> > > > >> > > > Hi! >> > > > >> > > > Is there any update regarding the rebase or the >> > > inclusion to >> > base >> > > >> > > > system? >> > > > On 3/28/18, Eric McCorkle <eric@metricspace.net >> > > <mailto: >> > eric@metricspace.net> >> > > >> > > > <mailto:eric@metricspace.net <mailto:eric@metricspace.n >> > > et>>> >> > wrote: >> > > >> > > > > I'll do another rebase from head just to be sure >> > > > > >> > > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh < >> > imp@bsdimp.com <mailto:imp@bsdimp.com> >> > > >> > > > <mailto:imp@bsdimp.com <mailto:imp@bsdimp.com>>> wrote: >> > > > >>It's on my list for nexr, finally. I have an >> > > alternate patch >> > for >> > > >> > > > >>loader.efi >> > > > >>from ESP, but i don't think it will affect the GELI >> > > stuff. I >> > have some >> > > >> > > > >>time >> > > > >>slotted for integration issues though. >> > > > >> >> > > > >>I am quite mindful of the freeze dates.... I have >> > > some uefi >> > boot >> > > >> > > > >>loader >> > > > >>protocol changes that I need to get in. >> > > > >> >> > > > >>Warner >> > > > >> >> > > > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" < >> > tommi.pernila@iki.fi <mailto:tommi.pernila@iki.fi> >> > > >> > > > <mailto:tommi.pernila@iki.fi <mailto:tommi.pernila@iki. >> > > fi>>> >> > wrote: >> > > >> > > > >> >> > > > >>> Awesome, thanks for the update and the work that >> > > you have >> > done! >> > > >> > > > >>> >> > > > >>> Now we just need some more reviewers eyes on the >> > > code :) >> > > > >>> >> > > > >>> Br, >> > > > >>> >> > > > >>> Tommi >> > > > >>> >> > > > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle < >> > eric@metricspace.net <mailto:eric@metricspace.net> >> > > >> > > > <mailto:eric@metricspace.net <mailto:eric@metricspace.n >> > > et>>> >> > > > >>wrote: >> > > > >>> >> > > > >>>> FYI, I just IFC'ed everything, and the current >> > > patches >> > > are still >> > > > >>fine. >> > > > >>>> >> > > > >>>> Also, the full GELI + standalone loader has been >> > > deployed >> > > on one of >> > > > >>my >> > > > >>>> laptops for some time now. >> > > > >>>> >> > > > >>>> On 02/21/2018 18:15, Eric McCorkle wrote: >> > > > >>>> > The GELI work could be merged at this point, >> > > though it >> > > won't be >> > > > >>usable >> > > > >>>> > without an additional patch to enable loader- >> > > only >> > > operation. The >> > > > >>>> > patches are currently up for review: >> > > > >>>> > >> > > > >>>> > This is the order in which they'd need to be >> > > merged: >> > > > >>>> > >> > > > >>>> > >> > > > >>>> > https://reviews.freebsd.org/D12732 >> > > <https://reviews.freebsd.org/D12732>; >> > > > <https://reviews.freebsd.org/D12732 >> > > <https://reviews.freebsd.org/D12732>>; >> > > > >>>> > >> > > > >>>> > This one changes the efipart device. Toomas >> > > Soome >> > > identified >> > > > some >> > > > >>>> > problems, which I have addressed. He has not >> > > re-reviewed it, >> > > > >>however. >> > > > >>>> > >> > > > >>>> > >> > > > >>>> > https://reviews.freebsd.org/D12692 >> > > <https://reviews.freebsd.org/D12692>; >> > > > <https://reviews.freebsd.org/D12692 >> > > <https://reviews.freebsd.org/D12692>>; >> > > > >>>> > >> > > > >>>> > This adds some crypto code needed for GELI. It >> > > simply >> > > adds new >> > > > >>code, >> > > > >>>> > and doesn't conflict with anything. >> > > > >>>> > >> > > > >>>> > >> > > > >>>> > https://reviews.freebsd.org/D12698 >> > > <https://reviews.freebsd.org/D12698>; >> > > > <https://reviews.freebsd.org/D12698 >> > > <https://reviews.freebsd.org/D12698>>; >> > > > >>>> > >> > > > >>>> > This adds the EFI KMS interface code, and has >> > > the EFI >> > > loader pass >> > > > >>keys >> > > > >>>> > into the keybuf interface. >> > > > >>>> > >> > > > >>>> > >> > > > >>>> > I can't post the main GELI driver until those >> > > get >> > > merged, as it >> > > > >>depends >> > > > >>>> > on them. It can be found on the geli branch on >> > > my >> > > github freebsd >> > > > >>>> > repository, however. >> > > > >>>> > >> > > > >>>> > >> > > > >>>> > Additionally, you need this patch, which allows >> > > loader.efi to >> > > > >>function >> > > > >>>> > when installed directly to the ESP: >> > > > >>>> > >> > > > >>>> > https://reviews.freebsd.org/D13497 >> > > <https://reviews.freebsd.org/D13497>; >> > > > <https://reviews.freebsd.org/D13497 >> > > <https://reviews.freebsd.org/D13497>>; >> > > > >>>> > >> > > > >>>> > On 02/20/2018 22:56, Tommi Pernila wrote: >> > > > >>>> >> Hi Eric, >> > > > >>>> >> >> > > > >>>> >> could you provide a brief update how the work >> > > is going? >> > > > >>>> >> >> > > > >>>> >> >> > > > >>>> >> Br, >> > > > >>>> >> >> > > > >>>> >> Tommi >> > > > >>>> >> >> > > > >>>> >> >> > > > >>>> >> On Nov 16, 2017 04:29, "Eric McCorkle" >> > > <eric@metricspace.net <mailto:eric@metricspace.net> >> > > > <mailto:eric@metricspace.net <mailto:eric@metricspace.n >> > > et>> >> > > > >>>> >> <mailto:eric@metricspace.net >> > > <mailto:eric@metricspace.net> <mailto:eric@metricspace.net >> > > <mailto:eric@metricspace.net>>>> >> > > > wrote: >> > > > >>>> >> >> > > > >>>> >> Right, so basically, the remaining GELI >> > > patches >> > > are against >> > > > >>>> loader, and >> > > > >>>> >> most of them can go in independently of the >> > > work >> > > on removing >> > > > >>boot1. >> > > > >>>> >> There's a unanimous consensus on getting >> > > rid of >> > > boot1 which >> > > > >>>> includes its >> > > > >>>> >> original author, so that's going to happen. >> > > > >>>> >> >> > > > >>>> >> >> > > > >>>> >> For GELI, we have the following (not >> > > necessarily >> > > in order): >> > > > >>>> >> >> > > > >>>> >> a) Adding the KMS interfaces, pseudo- >> > > device, and >> > > kernel >> > > > >>keybuf >> > > > >>>> >> interactions >> > > > >>>> >> b) Modifications to the efipart driver >> > > > >>>> >> c) boot crypto >> > > > >>>> >> d) GELI partition types (not strictly >> > > necessary) >> > > > >>>> >> >> > > > >>>> >> Then there's the GELI driver itself. (a) >> > > and (c) >> > are >> > > >> > > > good to >> > > > >>>> land, (b) >> > > > >>>> >> needs some more work after Toomas Soome >> > > pointed >> > out a >> > > >> > > > >>legitimate >> > > > >>>> >> problem, and (d) actually needs a good bit >> > > more >> > > code (but >> > > > >>again, >> > > > >>>> it's >> > > > >>>> >> more cosmetic). Additionally, the GELI >> > > driver >> > > will need >> > > > >>further >> > > > >>>> mods to >> > > > >>>> >> efipart to be written (nothing too >> > > big). But we >> > > could go >> > > > >>ahead >> > > > >>>> with (a) >> > > > >>>> >> and (c), as they've already been proven to >> > > work. >> > > > >>>> >> >> > > > >>>> >> I'd wanted to have this stuff shaped up >> > > sooner, >> > > but I'm >> > > > >>>> preoccupied with >> > > > >>>> >> the 7th RISC-V workshop at the end of the >> > > month. >> > > > >>>> >> >> > > > >>>> >> Once this stuff is all in, loader should >> > > handle >> > > any GELI >> > > > >>volumes it >> > > > >>>> >> finds, and it should Just Work once boot1 >> > > is gone. >> > > > >>>> >> >> > > > >>>> >> >> > > > >>>> > _______________________________________________ >> > > > >>>> > freebsd-current@freebsd.org >> > > <mailto:freebsd-current@freebsd.org> >> > > > <mailto:freebsd-current@freebsd.org >> > > <mailto:freebsd-current@freebsd.org>> mailing list >> > > > >>>> > https://lists.freebsd.org/mailman/listinfo/freeb >> > > sd- >> > current >> > > >> > > <https://lists.freebsd.org/mailman/listinfo/freebsd-current>; >> > > > <https://lists.freebsd.org/mailman/listinfo/freebsd-cur >> > > rent >> > > <https://lists.freebsd.org/mailman/listinfo/freebsd-current>>; >> > > > >>>> > To unsubscribe, send any mail to >> > "freebsd-current-unsubscribe@ >> > > >> > > > >>>> freebsd.org <http://freebsd.org>; >> > > <http://freebsd.org>" >> > > > >>>> > >> > > > >>>> >> > > > >>> >> > > > > >> > > > > -- >> > > > > Sent from my Android device with K-9 Mail. Please >> > > excuse my >> > brevity. >> > > >> > > > > _______________________________________________ >> > > > > freebsd-current@freebsd.org >> > > <mailto:freebsd-current@freebsd.org> >> > > <mailto:freebsd-current@freebsd.org >> > > <mailto:freebsd-current@freebsd.org>> >> > > > mailing list >> > > > > https://lists.freebsd.org/mailman/listinfo/freebsd-cu >> > > rrent >> > > <https://lists.freebsd.org/mailman/listinfo/freebsd-current>; >> > > > <https://lists.freebsd.org/mailman/listinfo/freebsd-cur >> > > rent >> > > <https://lists.freebsd.org/mailman/listinfo/freebsd-current>>; >> > > > > To unsubscribe, send any mail to >> > > > "freebsd-current-unsubscribe@freebsd.org >> > > <mailto:freebsd-current-unsubscribe@freebsd.org> >> > > > <mailto:freebsd-current-unsubscribe@freebsd.org >> > > <mailto:freebsd-current-unsubscribe@freebsd.org>>" >> > > > > >> > > > >> > > > >> > > >> > > >> > >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd >> .org" -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From owner-freebsd-current@freebsd.org Sun Jul 8 23:10:30 2018 Return-Path: <owner-freebsd-current@freebsd.org> Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41B611041591 for <freebsd-current@mailman.ysv.freebsd.org>; Sun, 8 Jul 2018 23:10:30 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic311-23.consmr.mail.gq1.yahoo.com (sonic311-23.consmr.mail.gq1.yahoo.com [98.137.65.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BDC2B71AE8 for <freebsd-current@freebsd.org>; Sun, 8 Jul 2018 23:10:29 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 8AWWRPcVM1lMSv62SsvJhEF4tYIHwWLqcOUr1Zdx48x3bl_qHs8Fbr3Zx4VVTQb mp1AfWKCbkOQc897NwR4Fc6wZg.lNTWKnUTmSe5wqQHRZgpKozZ4nZGxuZZK1Lzv6gVSi.wrOtwi Hlws2ScJzs1vTTnAlJygxfnJBM0p5Mdujm44RgRwk39EIlJgEqPCxG74e2XXtWQRxy1z06A53.r7 8oMm49iR1OJTFbstrrg_SavUjiS.fRb7.34God8DKmxffuBpfz40d2I5SAMliJrj1xntwVY6XZ_S pfYTX.wtETIyo_72iu5TDymHyOLWNt.VlobtM_50PTHqZnqXA8t.292Xc5jZRizqi5NcJZKJqr_k NWpM6UU3u9DZC9wxtfA5qO9W8uZm27sW0S6m3BiDYZh9A392ocIQWZYNjYBhg5dbgM4gWLfrh6UF tQ30MV861hQceS2OKoyzK1SYNNUJuNkNaApuETH7r1TUUxfma1GMeheT0Fe2U9zwn8fwJg0mJesW DCA23yrJDsmWfbDZqZ9FHAMv7uZVE61Gu___70dFGQ667ycsHfW0FwuaEvr0PZRzqrjUW26VfYMe F16uLUauPg9ss75c5NQkyXlDPB7_QaUjeVUw0mFv731Me.BV5d2bbgXMVuNgFM6ee3_o8N_3baZY xaYbsBlmMXzYYf7pm8HhwHV7pUPKr5MkEDqZqYNZgJeLpmePOueYkULLhznLe9.LMslrddfD763y u6LDYjqD6afPKm9ScVB3fClw.tKIn1HXlWSpsvM6LcfLw0Xk3eCNJ5_P87EDS436fIyjlTparhnm Ot4NXxNfbPmqNyf_ILUUCTwzWQpR4QgwgVnaYqPwuGfgzC.AQrklNDZslFPYzQxpaCEs9DEafht3 0nLcpEigAdgx.E9Fak4pkeh3wJzCBRhrddCOjcox_HCHqKmaMXIsMUAEJFFB9uiB3ukCZETEU754 T2bXu4HaAXxPWUejBJUNS751_DdRJYHCI.uhTWd.7hWibWXWc6g8JbUZ4qfsxaauTMu0Leg-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Sun, 8 Jul 2018 23:10:28 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp429.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID e23d720e7c01344b787537e197b6fb72; Sun, 08 Jul 2018 22:50:10 +0000 (UTC) From: Mark Millard <marklmi@yahoo.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: -r336099 and later: broke ci.freebsd.prg's FreeBSD-head-amd64-build Message-Id: <6EA9A549-7508-467C-BED2-AF0C136C752D@yahoo.com> Date: Sun, 8 Jul 2018 15:50:09 -0700 To: Warner Losh <imp@bsdimp.com>, FreeBSD Current <freebsd-current@freebsd.org> X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>; List-Post: <mailto:freebsd-current@freebsd.org> List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 08 Jul 2018 23:10:30 -0000 https://ci.freebsd.org/job/FreeBSD-head-amd64-build/9386/consoleText shows: ===> zlib (install) install -T release -o root -g wheel -m 555 zlib.ko /usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel/ install -T debug -o root -g wheel -m 555 zlib.ko.debug /usr/obj/usr/src/amd64.amd64/release/dist/kernel/usr/lib/debug/boot/kernel/ kldxref /usr/obj/usr/src/amd64.amd64/release/dist/kernel/boot/kernel kldxref: Parse error of description string U16:vendor; U16:device *** Error code 1 Stop. make[4]: stopped in /usr/src/sys/modules Note the "U16:vendor; U16:device" reference and such text in the below (and other check-ins after it). . . Author: imp Date: Sun Jul 8 20:39:38 2018 New Revision: 336099 URL: https://svnweb.freebsd.org/changeset/base/336099 Log: Add PNP info to PCI attachment of ena driver . . . Modified: head/sys/dev/ena/ena.c head/sys/dev/ena/ena.h Modified: head/sys/dev/ena/ena.c ============================================================================== --- head/sys/dev/ena/ena.c Sun Jul 8 20:39:23 2018 (r336098) +++ head/sys/dev/ena/ena.c Sun Jul 8 20:39:38 2018 (r336099) @@ -3947,6 +3947,8 @@ static driver_t ena_driver = { devclass_t ena_devclass; DRIVER_MODULE(ena, pci, ena_driver, ena_devclass, 0, 0); +MODULE_PNP_INFO("U16:vendor; U16:device", pci, ena, ena_vendor_info_array, + sizeof(ena_vendor_info_array[0]), nitems(ena_vendor_info_array) - 1); MODULE_DEPEND(ena, pci, 1, 1, 1); MODULE_DEPEND(ena, ether, 1, 1, 1); . . . === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8AFC01EE-A37A-4D89-9A67-8707AA3184DD>