From owner-p4-projects@FreeBSD.ORG Fri Sep 19 06:20:15 2014 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A14FEE6F; Fri, 19 Sep 2014 06:20:15 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 63520E6D for ; Fri, 19 Sep 2014 06:20:15 +0000 (UTC) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:1900:2254:2068::682:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4EF66D8A for ; Fri, 19 Sep 2014 06:20:15 +0000 (UTC) Received: from skunkworks.freebsd.org ([127.0.1.74]) by skunkworks.freebsd.org (8.14.9/8.14.9) with ESMTP id s8J6KFo2006162 for ; Fri, 19 Sep 2014 06:20:15 GMT (envelope-from jmg@freebsd.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.9/8.14.9/Submit) id s8J6KFLe006156 for perforce@freebsd.org; Fri, 19 Sep 2014 06:20:15 GMT (envelope-from jmg@freebsd.org) Date: Fri, 19 Sep 2014 06:20:15 GMT Message-Id: <201409190620.s8J6KFLe006156@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to jmg@freebsd.org using -f From: John-Mark Gurney Subject: PERFORCE change 1200497 for review To: Perforce Change Reviews Precedence: bulk X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.18-1 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 06:20:15 -0000 http://p4web.freebsd.org/@@1200497?ac=10 Change 1200497 by jmg@jmg_carbon2 on 2014/09/19 06:19:18 document that the nonce/IV is required on every call for both GCM and ICM... This is because if you call w/ the same key and use a random IV, it is possible after enough calls that there might be a collision which would compromise security... Sponsored by: FreeBSD Foundation Sponsored by: Rubicon Communications, LLC (Netgate) Affected files ... .. //depot/projects/opencrypto/share/man/man7/crypto.7#3 edit Differences ... ==== //depot/projects/opencrypto/share/man/man7/crypto.7#3 (text+ko) ==== @@ -77,6 +77,8 @@ The associated data (if any) must be provided by the authentication mode op. The authentication tag will be read/written from/to the offset crd_inject of the authentication mode. +.Pp +Note: You must provide an IV on every call. .It Dv CRYPTO_AES_ICM .Bl -tag -width "Block size :" -compact -offset indent .It IV size : @@ -94,6 +96,8 @@ This does mean that if a counter is required that rolls over at 32 bits, the transaction need to be split into two parts where the counter rolls over. The counter incremented as a 128-bit big endian number. +.Pp +Note: You must provide an IV on every call. .It Dv CRYPTO_AES_XTS .Bl -tag -width "Block size :" -compact -offset indent .It IV size :