From owner-cvs-all@FreeBSD.ORG Mon Aug 16 03:18:21 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D335E16A4CE; Mon, 16 Aug 2004 03:18:21 +0000 (GMT) Received: from green.homeunix.org (pcp04371970pcs.nrockv01.md.comcast.net [69.140.223.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4687443D1F; Mon, 16 Aug 2004 03:18:21 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i7G3IKwJ004007; Sun, 15 Aug 2004 23:18:20 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i7G3IKs5004006; Sun, 15 Aug 2004 23:18:20 -0400 (EDT) (envelope-from green) Date: Sun, 15 Aug 2004 23:18:20 -0400 From: Brian Fundakowski Feldman To: Garance A Drosihn , bde@FreeBSD.org Message-ID: <20040816031820.GA980@green.homeunix.org> References: <200408150624.i7F6OhhR074096@repoman.freebsd.org> <20040816014244.GB3026@green.homeunix.org> <20040816015108.GQ991@funkthat.com> <20040816023851.GC3026@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: John-Mark Gurney cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2004 03:18:22 -0000 On Sun, Aug 15, 2004 at 11:00:14PM -0400, Garance A Drosihn wrote: > At 10:38 PM -0400 8/15/04, Brian Fundakowski Feldman wrote: > >On Sun, Aug 15, 2004 at 06:51:08PM -0700, John-Mark Gurney wrote: > > > > > > sure, I'd like a quick peak at the patch though (if it takes me > > > more than a day, go ahead and commit). > > > >I'd very much like you to look it over. I haven't tested it, just > >made the stylistic changes. If it were more complete (i.e. satisfy > >bde), every spurious blank line (that is, all of them inside functions > >which are not between variable declarations and code) would be gone, > >too, but that can be kind of harsh. > > > >--- /usr/src/sys/kern/kern_event.c Sun Aug 15 15:44:41 2004 > >+++ kern_event.c Sun Aug 15 22:36:25 2004 > > >@@ -232,7 +231,6 @@ > > static int > > filt_fileattach(struct knote *kn) > > { > >- > > return (fo_kqfilter(kn->kn_fp, kn)); > > } > > > > In some cases, such as this one, you are removing a blank line > which style(9) wants to have there. ISTR being told that if there > are no local variables in a routine, there should be a blank line > before the first executable statement. Looking at the man page, I > think that is shown by the example: > > static void > usage() > { > /* Insert an empty line if the function has no local variables. */ That example actually shows there being a non-empty line where variable declaration would have been... I never knew exactly what to make of it. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\