Date: Thu, 26 Oct 2000 14:00:03 -0700 (PDT) From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/10778: "ipforward_rt" is not cleared when routing table changes Message-ID: <200010262100.OAA30248@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/10778; it has been noted by GNATS. From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> To: John Polstra <jdp@polstra.com> Cc: freebsd-gnats-submit@freebsd.org Subject: Re: kern/10778: "ipforward_rt" is not cleared when routing table changes Date: Thu, 26 Oct 2000 16:54:42 -0400 (EDT) <<On Thu, 26 Oct 2000 11:09:33 -0700 (PDT), John Polstra <jdp@polstra.com> said: > One easy hack would be to ignore ipforward_rt if it is more than, say, > 2 seconds old. This isn't a real fix, but it would at least limit the > duration of the damage. The performance penalty would be negligible > in real life. Yes, this is a bug. The right fix is to change the IP code so that, when it gets notified of a routing change, ipforward_rt (and presumably ip6forward_rt if there is such a thing) get cleared automatically. This could easily be done in a couple of lines in netinet/in_rmx.c:in_addroute(). ipforward_rt would also have to be unstaticked in ip_input.c and declared in a useful header file. The code which would make things Just Work doesn't happen in the forwarding case because protocol-based cloning is (intentionally) disabled. -GAWollman To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010262100.OAA30248>