From owner-svn-src-all@FreeBSD.ORG Tue Nov 19 14:30:46 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0A4E1C21; Tue, 19 Nov 2013 14:30:46 +0000 (UTC) Received: from mail-ea0-x236.google.com (mail-ea0-x236.google.com [IPv6:2a00:1450:4013:c01::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2713523F8; Tue, 19 Nov 2013 14:30:45 +0000 (UTC) Received: by mail-ea0-f182.google.com with SMTP id o10so4011811eaj.27 for ; Tue, 19 Nov 2013 06:30:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=y5+dcKh0er1dwGro6JOoXvK2CTLnB2O/BqThTdT+KxU=; b=WsSiM4E4V7AmEXtlS+dBUMEWioDjYvwo/iRYBX+jP6aH++1achkIWVmVdqoUD3qw2z cBu7rpjxQJiZwqG/RvMWnrKL5kDQY2bXcUdrlvMOBoCTgl0+GZv3TaH9SSIVWejYGSCB 1wILrs0oCxCdbev6eSOcqPjJ0zEq0xGGAR/ijSqw4r4taWfIm58LaoSGze8wQCEH46N/ KjtZAyclKjStNDO7hLWRz40tNDRNef7Ig7Qx1oLM/64OatmHo+1UsxOjKYGrn1B2lSdQ y0zohq1oES4ltOSo13AYs/FuZrWFdbdjdoAJSJCvsF+oZB4XoBmSAAUY/31DAnzVbCD2 ZltA== X-Received: by 10.14.176.3 with SMTP id a3mr633258eem.109.1384871443544; Tue, 19 Nov 2013 06:30:43 -0800 (PST) Received: from mavbook.mavhome.dp.ua ([178.137.150.35]) by mx.google.com with ESMTPSA id z1sm49364304eeo.14.2013.11.19.06.30.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 19 Nov 2013 06:30:42 -0800 (PST) Sender: Alexander Motin Message-ID: <528B760F.3010001@FreeBSD.org> Date: Tue, 19 Nov 2013 16:30:39 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: svn commit: r258336 - head/sys/vm References: <201311191005.rAJA5snM048103@svn.freebsd.org> <20131119121109.GG7577@FreeBSD.org> <20131119121206.GH7577@FreeBSD.org> In-Reply-To: <20131119121206.GH7577@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 14:30:46 -0000 On 19.11.2013 14:12, Gleb Smirnoff wrote: > On Tue, Nov 19, 2013 at 04:11:09PM +0400, Gleb Smirnoff wrote: > T> Alexander, > T> > T> On Tue, Nov 19, 2013 at 10:05:53AM +0000, Alexander Motin wrote: > T> A> Author: mav > T> A> Date: Tue Nov 19 10:05:53 2013 > T> A> New Revision: 258336 > T> A> URL: http://svnweb.freebsd.org/changeset/base/258336 > T> A> > T> A> Log: > T> A> Implement soft pressure on UMA cache bucket sizes. > T> A> > T> A> Every time system detects low memory condition decrease bucket sizes for > T> A> each zone by one item. As result, higher memory pressure will push to > T> A> smaller bucket sizes and so smaller per-CPU caches and so more efficient > T> A> memory use. > T> A> > T> A> Before this change there was no force to oppose buckets growth as result > T> A> of practically inevitable zone lock conflicts, and after some run time > T> A> per-CPU caches could consume enough RAM to kill the system. > T> > T> Brief review of patch tells me that system never recovers from this. uz_count > T> it decremented only and never incremented. You are wrong. uz_count is incremented in uma_zalloc_arg() same as it was always before. Probably it was too brief review. :) > Do I understand right that r258338 fixes that? Not fixes (since there was no bug), but adds second increment point. -- Alexander Motin