From owner-cvs-all@FreeBSD.ORG Tue Apr 10 19:49:46 2012 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 609ED1065673 for ; Tue, 10 Apr 2012 19:49:46 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 131AB8FC15 for ; Tue, 10 Apr 2012 19:49:46 +0000 (UTC) Received: by obbwc18 with SMTP id wc18so253374obb.13 for ; Tue, 10 Apr 2012 12:49:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=zyKMj6/ThbFeWDgexWSkCv/yPZZWy3eD2qiUt1AVLCk=; b=N/LgmhbMf5HJj3oF8pmkE82eE4hNtduzVUgIUE1tUKBjk92aqSBAc8XaIF5+8Rdgh8 P2z2dTuYz/MxKhitRhkFPf8V93bZToFe4C/YGuygcJiBDxa6IJ/cXNpaWasTeqExV7L8 hhC52/EaovLndAkGNAtQ8GkNt5Hi3rAWLiY27uUhMu3b/Wdq3tPD6aOCJM8E7jzDMv12 WV7m8nktUpmqYnMrGYyH6eI51eDgHDHWhdtIJyPe/gomBAndQYNvU6ByAzqh4sb43hBM ULiSbnP2lhu5FdfSKWc5KaJTOLMYlGwJjSJeYVd2IX9tOzkLpd3FiKXBit1HXBPU2jMo 6LCA== Received: by 10.182.111.3 with SMTP id ie3mr17977749obb.14.1334087385370; Tue, 10 Apr 2012 12:49:45 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id ch5sm346014obb.16.2012.04.10.12.49.43 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 10 Apr 2012 12:49:43 -0700 (PDT) Sender: Jason Helfman Date: Tue, 10 Apr 2012 12:48:39 -0700 From: Jason Helfman To: Olli Hauer Message-ID: <20120410194839.GB83964@dormouse.experts-exchange.com> References: <201204092207.q39M7Qdp013689@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <201204092207.q39M7Qdp013689@repoman.freebsd.org> X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnwXS+GmRqQrsE9DNsftLayVVqhkqxjQtGtocG/Q03ftb2+X9atcAxIFah3o7hcJVgAUJYV Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/rancid Makefile distinfo pkg-plist ports/net-mgmt/rancid/files patch-bin-rancid.in patch-bin__control_rancid.in patch-etc::Makefile.am patch-etc::Makefile.in patch-etc__Makefile.am patch-etc__Makefile.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2012 19:49:46 -0000 On Mon, Apr 09, 2012 at 10:07:26PM +0000, Olli Hauer thus spake: >ohauer 2012-04-09 22:07:26 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/rancid Makefile distinfo pkg-plist > Added files: > net-mgmt/rancid/files patch-bin__control_rancid.in > patch-etc__Makefile.am > patch-etc__Makefile.in > Removed files: > net-mgmt/rancid/files patch-bin-rancid.in > patch-etc::Makefile.am > patch-etc::Makefile.in > Log: > - update to version 2.3.8 > > Changes: > http://www.shrubbery.net/rancid/CHANGES > > Additional portlint fixes > > PR: 165974 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=165974 > Submitted by: ohauer > Approved by: Mohacsi Janos (maintainer) > Feature safe: yes > > Revision Changes Path > 1.32 +5 -5 ports/net-mgmt/rancid/Makefile > 1.12 +2 -2 ports/net-mgmt/rancid/distinfo > 1.2 +0 -13 ports/net-mgmt/rancid/files/patch-bin-rancid.in (dead) > 1.1 +13 -0 ports/net-mgmt/rancid/files/patch-bin__control_rancid.in (new) > 1.4 +0 -34 ports/net-mgmt/rancid/files/patch-etc::Makefile.am (dead) > 1.4 +0 -34 ports/net-mgmt/rancid/files/patch-etc::Makefile.in (dead) > 1.1 +31 -0 ports/net-mgmt/rancid/files/patch-etc__Makefile.am (new) > 1.1 +31 -0 ports/net-mgmt/rancid/files/patch-etc__Makefile.in (new) > 1.14 +3 -0 ports/net-mgmt/rancid/pkg-plist > >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/Makefile.diff?&r1=1.31&r2=1.32&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/distinfo.diff?&r1=1.11&r2=1.12&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-bin-rancid.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-bin__control_rancid.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc::Makefile.am >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc::Makefile.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc__Makefile.am >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/files/patch-etc__Makefile.in >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/rancid/pkg-plist.diff?&r1=1.13&r2=1.14&f=h > Can you please look at this pr, as I took it for a rancid update. http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166585 This port doesn't consider package installation users and clobbers existing configurations. Per the Handbook: If there is a very good reason not to install a working configuration file by default, leave the @exec line out of pkg-plist and add a message pointing out that the user must copy and edit the file before the software will work. Regarding the handbook entry, I don't know if this is the case for this software, but I put the pr into feedback so I could engage the maintainer regarding this, but have not heard anything. Thanks -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh