From owner-dev-commits-doc-all@freebsd.org Wed Jun 16 22:16:37 2021 Return-Path: Delivered-To: dev-commits-doc-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D5D55645D5C for ; Wed, 16 Jun 2021 22:16:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G50055PDDz4S5m; Wed, 16 Jun 2021 22:16:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A16B823A2B; Wed, 16 Jun 2021 22:16:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 15GMGbIo076894; Wed, 16 Jun 2021 22:16:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 15GMGbDj076893; Wed, 16 Jun 2021 22:16:37 GMT (envelope-from git) Date: Wed, 16 Jun 2021 22:16:37 GMT Message-Id: <202106162216.15GMGbDj076893@gitrepo.freebsd.org> To: doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org From: Warner Losh Subject: git: 8d6cf88d2f - main - committers-guide: Add note to check for default anonymous github names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: doc X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8d6cf88d2faad4c9ce4c8e6e23ac041b42f969f4 Auto-Submitted: auto-generated X-BeenThere: dev-commits-doc-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the doc repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 22:16:37 -0000 The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/doc/commit/?id=8d6cf88d2faad4c9ce4c8e6e23ac041b42f969f4 commit 8d6cf88d2faad4c9ce4c8e6e23ac041b42f969f4 Author: Warner Losh AuthorDate: 2021-06-16 22:14:34 +0000 Commit: Warner Losh CommitDate: 2021-06-16 22:14:34 +0000 committers-guide: Add note to check for default anonymous github names Github generates names like github-user <38923459+github-user@users.noreply.github.com> for it's web-created content. Add a note for people doing pull requests to check for this construct and to request a real name. Sponsored by: Netflix --- .../content/en/articles/committers-guide/_index.adoc | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/documentation/content/en/articles/committers-guide/_index.adoc b/documentation/content/en/articles/committers-guide/_index.adoc index 9998694e0f..fffc6ef128 100644 --- a/documentation/content/en/articles/committers-guide/_index.adoc +++ b/documentation/content/en/articles/committers-guide/_index.adoc @@ -2329,6 +2329,17 @@ However, when there's multiple commits, especially when minor adjustments are ne Briefly, these commands create a branch; cherry-picks the changes from the pull request; tests it; adjusts the commit messages; and fast forward merges it back to `main`. The PR number is `$PR` below. When adjusting the message, add `Pull Request: https://github.com/freebsd-src/pull/$PR`. +[NOTE] +====== +In addition, please check to make sure that the pull request author name is not anonymous. +Github's web interface generates names like: +[source,shell] +.... +Author: github-user <38923459+github-user@users.noreply.github.com> +.... +A polite request to the author for a better name and/or email should be made. +====== + [source,shell] .... % git fetch github pull/$PR/head:staging