From owner-freebsd-current@FreeBSD.ORG  Wed Aug 23 19:20:25 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 909D416A51B;
	Wed, 23 Aug 2006 19:20:25 +0000 (UTC)
	(envelope-from maxim@macomnet.ru)
Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4FFAD43D9E;
	Wed, 23 Aug 2006 19:20:14 +0000 (GMT)
	(envelope-from maxim@macomnet.ru)
Received: from localhost (localhost.int.ru [127.0.0.1] (may be forged))
	by mp2.macomnet.net (8.13.7/8.13.3) with ESMTP id k7NJK95E045766;
	Wed, 23 Aug 2006 23:20:10 +0400 (MSD)
	(envelope-from maxim@macomnet.ru)
Date: Wed, 23 Aug 2006 23:20:09 +0400 (MSD)
From: Maxim Konovalov <maxim@macomnet.ru>
To: "Alexander I. Mogilny" <amogilny@gmail.com>
In-Reply-To: <20060823173817.GA37159@astral.ntu-kpi.kiev.ua>
Message-ID: <20060823231846.S45478@mp2.macomnet.net>
References: <20060823173817.GA37159@astral.ntu-kpi.kiev.ua>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: freebsd-current@freebsd.org, glebius@freebsd.org, sg@astral.ntu-kpi.kiev.ua
Subject: Re: [patch] buildkernel crash [brgphy.c.patch]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Aug 2006 19:20:25 -0000

On Wed, 23 Aug 2006, 20:38+0300, Alexander I. Mogilny wrote:

> I have just tried to migrate from i386 to amd64 architecture on my
> nx6125 laptop and failed to build kernel:
>
> make TARGET_ARCH=amd64 buildkernel
>
> error was:
>
> /usr/src/sys/dev/mii/brgphy.c: In function `brgphy_reset':
> /usr/src/sys/dev/mii/brgphy.c:646: error: structure has no member named `bge_no_3_led'
> *** Error code 1
>
> Stop in /usr/obj/amd64/usr/src/sys/GENERIC.
> *** Error code 1
>
> I have checked recent commits to bge driver and found that glebius
> made some changes to if_bgereg.h file which removed bge_no_3_led
> field from bge_softc struct.
>
> Here is the patch fixing it:
>
>
> --- brgphy.c.orig	Wed Aug 23 20:18:28 2006
> +++ brgphy.c	Wed Aug 23 20:35:37 2006
> @@ -643,7 +643,7 @@
>  		PHY_WRITE(sc, BRGPHY_MII_AUXCTL, val | (1 << 15) | (1 << 4));
>
>  		/* Enable Link LED on Dell boxes */
> -		if (bge_sc->bge_no_3_led) {
> +		if (bge_sc->bge_flags & BGE_FLAG_NO3LED) {
>  			PHY_WRITE(sc, BRGPHY_MII_PHY_EXTCTL,
>  		    	PHY_READ(sc, BRGPHY_MII_PHY_EXTCTL)
>  			    & ~BRGPHY_PHY_EXTCTL_3_LED);

The code is already there, you need rev. 1.45.

-- 
Maxim Konovalov