From owner-freebsd-current@FreeBSD.ORG Wed Jul 4 14:36:45 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4C4E716A400 for ; Wed, 4 Jul 2007 14:36:45 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id A958C13C45D for ; Wed, 4 Jul 2007 14:36:44 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l64Eag0p031390; Wed, 4 Jul 2007 18:36:42 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru; s=default; t=1183559802; bh=itQHNFcg2wwCfulGRg+4Zop94jRGLhHrQBi3Fax WeuQ=; l=721; h=Received:Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=i9haIVZP0w8SjP80WznV Ob0ByJFLM7kVDv9dlLMgZ2qK/2TRrxRm8HOaWgfYmnraHwo3d0ObSje1pR+E5UQW1ug 63o7LwPUA/t4Z8KmhIE8UUBs7Nl54V86GsxDo3hnIqfLKPI4p//633WlsLvQx8xa4gX kaA3DnUFABshM7Wjg= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l64EagKA031389; Wed, 4 Jul 2007 18:36:42 +0400 (MSD) (envelope-from ache) Date: Wed, 4 Jul 2007 18:36:42 +0400 From: Andrey Chernov To: Michal Mertl Message-ID: <20070704143642.GA31254@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Michal Mertl , freebsd-current , scf@freebsd.org References: <1183557221.1799.16.camel@genius.i.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1183557221.1799.16.camel@genius.i.cz> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-current , scf@freebsd.org Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2007 14:36:45 -0000 On Wed, Jul 04, 2007 at 03:53:41PM +0200, Michal Mertl wrote: > I have tracked it down to the changes in {get,set,put}env and > src/bin/sh/var.c 1.36. I have checked (by inserting printf just before > the call) that the arguments passed to putenv() in var.c are reasonable, > yet the above mentioned warning is issued. 1) I don't check it yet, but there is no putenv() calls in var.c 1.36 in anycase. 2) "s" may point to getenv()-provided value there. So just modifying it directly followed by setenv() call will make things inconsistent. 3) In my version of patch there was savestr() which copy arg to avoid this situation. Fix will be to restore var.c to mine variant 1.34 -- http://ache.pp.ru/