From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Nov  8 15:20:11 2010
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C317B1065697
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon,  8 Nov 2010 15:20:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id BC6EF8FC28
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Mon,  8 Nov 2010 15:20:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA8FK95Z053595
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Mon, 8 Nov 2010 15:20:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA8FK98D053594;
	Mon, 8 Nov 2010 15:20:09 GMT (envelope-from gnats)
Resent-Date: Mon, 8 Nov 2010 15:20:09 GMT
Resent-Message-Id: <201011081520.oA8FK98D053594@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Eitan Adler <lists@eitanadler.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D4583106566C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  8 Nov 2010 15:18:05 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id C29608FC19
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  8 Nov 2010 15:18:05 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oA8FI5im085321
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 8 Nov 2010 15:18:05 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id oA8FI5ak085320;
	Mon, 8 Nov 2010 15:18:05 GMT (envelope-from nobody)
Message-Id: <201011081518.oA8FI5ak085320@www.freebsd.org>
Date: Mon, 8 Nov 2010 15:18:05 GMT
From: Eitan Adler <lists@eitanadler.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: ports/152053: [patch] portlint shouldn't report that 'work' isn't
	in cvs
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Nov 2010 15:20:11 -0000


>Number:         152053
>Category:       ports
>Synopsis:       [patch] portlint shouldn't report that 'work' isn't in cvs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 08 15:20:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
portlint currently reports two conflicting messages when it finds a
"work" directory in a port
a) Make sure it isn't committed
b) It was not found in CVS


>How-To-Repeat:

>Fix:
This patch silences the second one

--- portlint.old        2010-11-05 14:02:28.000000000 -0400
+++ portlint    2010-11-07 20:58:57.000000000 -0500
@@ -464,7 +464,7 @@
                               if /^(?:\.\.?|CVS)$/;
                       my $filename = $dir eq '.' ? $_ : "$dir/$_";
                       if (-d $filename) {
-                               if (!$entries{$_} || $entries{$_} ne 'D') {
+                               if ((!$entries{$_} || $entries{$_} ne 'D') && $filename ne 'work') {
                                       &perror("FATAL", "", -1, "directory $filename not in CVS.");
                               }
                               else {


>Release-Note:
>Audit-Trail:
>Unformatted: