From owner-svn-src-head@FreeBSD.ORG Tue Aug 19 21:08:50 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7E2E86DE; Tue, 19 Aug 2014 21:08:50 +0000 (UTC) Received: from mail-ig0-x231.google.com (mail-ig0-x231.google.com [IPv6:2607:f8b0:4001:c05::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 312D8300F; Tue, 19 Aug 2014 21:08:50 +0000 (UTC) Received: by mail-ig0-f177.google.com with SMTP id hn18so10301119igb.4 for ; Tue, 19 Aug 2014 14:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+dzADuAfNud3urB6BGywX9IUdtgifZXgba0cb9B2jz8=; b=KGlpkM3uAp3PMrP4+rpf0993R6bbY93CbmqKT3hK6vihQu9qU0OtqAPUlRIPmuwf62 4p1K+L2CsXCnM/KFLzApNlHzNtVUqIqhlIJaIeOlo1n3dARpTrTqpLNDXr11LXQJUZ6L OQF6IxC5TZRkXiOCbzFrgrznUDtx5IxTEprdG9ouYWB/hJdQypcK2ntp/6YkaLdiik1c aOa8S31hGpYFpTxaJKw9Z1cdPkS4LZ4/PreWHsQNOhAIaVTdZkSqFZ/gbculUjTbsfqt gfEoDaAF8BtJA5GDqougxqxQpM9XhrwtCR7XqYWqBN4fpQ2IAFtgtW4b4Y11KsYrsimk 3sug== MIME-Version: 1.0 X-Received: by 10.50.35.133 with SMTP id h5mr8565459igj.26.1408482529671; Tue, 19 Aug 2014 14:08:49 -0700 (PDT) Received: by 10.50.72.69 with HTTP; Tue, 19 Aug 2014 14:08:49 -0700 (PDT) In-Reply-To: <201408192104.s7JL4WKo059223@svn.freebsd.org> References: <201408192104.s7JL4WKo059223@svn.freebsd.org> Date: Tue, 19 Aug 2014 14:08:49 -0700 Message-ID: Subject: Re: svn commit: r270183 - head/usr.sbin/mountd From: Garrett Cooper To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Aug 2014 21:08:50 -0000 On Tue, Aug 19, 2014 at 2:04 PM, Bryan Drewery wrote: > Author: bdrewery > Date: Tue Aug 19 21:04:31 2014 > New Revision: 270183 > URL: http://svnweb.freebsd.org/changeset/base/270183 > > Log: > Avoid showing stale errors when nmount(2) fails. > > Sometimes nmount(2) will fail without setting errmsg. The previous (ignored) > error would then be shown as the reason for the failed call if the next > nmount(2) also fails without [ENOENT,ENOTSUP]. > > An example is when there is a tmpfs mounted with -o size. vfs_filteropt() adds > 'size' as an error in errmsg due to 'size' not being in tmpfs_updateopts. Then > tmpfs_mount returns [ENOTSUP] from nmount(2), which is then ignored. The next > call may race with an unmount causing an invalid [EINVAL] that then does log an > error, with the tmpfs errmsg. > > The race itself is a separate issue to fix as it is expected to have an > [ENOENT] returned instead. > > In this example the mount being shown is actually nullfs, not tmpfs that the > error is from. > > mountd[740]: can't delete exports for /poudriere/data/.m/exp-head-commit-test-devel/04/.npkg: Invalid argument mount option is unknown > > It should only show: > > mountd[740]: can't delete exports for /poudriere/data/.m/exp-head-commit-test-devel/04/.npkg: Invalid argument > > MFC after: 2 weeks Hmm -- I wonder if this is related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191218 ... Guess I get to retest that bug after this commit :)!