Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Apr 2021 11:03:00 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 250335] ports-mgmt/portmaster: tries to build devel/git@lite even if devel/git@default is already installed
Message-ID:  <bug-250335-7788-5F9uYeLRu0@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-250335-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-250335-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250335

Stefan E=C3=9Fer <se@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Open                        |Closed

--- Comment #5 from Stefan E=C3=9Fer <se@FreeBSD.org> ---
This should have been fixed with commit
a18733148a22a230caabc9295ef99c5840bdc43d on 2020-04-08. Please text again a=
nd
re-open the PR if the issue persists.

The cause was an optimization in portmaster, which made it skip the expensi=
ve
conflicts check if there were no lines starting with "CONFLICTS" in the
Makefile.

In devel/git/Makefile there are CONFLICTS definitions for each FLAVOR, pref=
ixed
by the flavor name, e.g. "lite_CONFLICTS_INSTALL", which did not match the
regular expression ^CONFLICTS.

This used to work in a pre-FLAVORs world, and while the regular expression
could be made less strict, this would not have solved an issue in some other
port, which got its CONFLICTS definitions only by including another port's
Makefile.

Therefore the optimization had to be removed, somewhat slowing down portmas=
ter
since it now has to invoke a complex shell script to test for conflicts with
installed packages even for ports that do not have any CONFLICTS defined.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-250335-7788-5F9uYeLRu0>