From owner-freebsd-ppc@freebsd.org Wed Feb 1 03:09:10 2017 Return-Path: Delivered-To: freebsd-ppc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6B6ACCBE93 for ; Wed, 1 Feb 2017 03:09:10 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-72.reflexion.net [208.70.210.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 658981BB6 for ; Wed, 1 Feb 2017 03:09:09 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 25493 invoked from network); 1 Feb 2017 03:09:02 -0000 Received: from unknown (HELO mail-cs-01.app.dca.reflexion.local) (10.81.19.1) by 0 (rfx-qmail) with SMTP; 1 Feb 2017 03:09:02 -0000 Received: by mail-cs-01.app.dca.reflexion.local (Reflexion email security v8.20.1) with SMTP; Tue, 31 Jan 2017 22:09:02 -0500 (EST) Received: (qmail 26684 invoked from network); 1 Feb 2017 03:09:02 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 1 Feb 2017 03:09:02 -0000 Received: from [192.168.1.111] (c-67-170-167-181.hsd1.or.comcast.net [67.170.167.181]) by iron2.pdx.net (Postfix) with ESMTPSA id E00BFEC8AEE; Tue, 31 Jan 2017 19:09:01 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: svn commit: r313005 - in head/sys: conf modules/zfs [The related 215947: -mlongcall use instead of -mminimal-toc] From: Mark Millard In-Reply-To: <2B31BF44-CB4F-4B07-AFFE-0D2083855BB2@gmail.com> Date: Tue, 31 Jan 2017 19:09:01 -0800 Cc: FreeBSD PowerPC ML Content-Transfer-Encoding: quoted-printable Message-Id: References: <676ECF89-F9AE-436A-942A-003B76C6BFE2@dsl-only.net> <2B31BF44-CB4F-4B07-AFFE-0D2083855BB2@gmail.com> To: Justin Hibbits X-Mailer: Apple Mail (2.3259) X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 03:09:10 -0000 On 2017-Jan-31, at 6:44 PM, Justin Hibbits = wrote: > On Jan 31, 2017, at 4:26 AM, Mark Millard wrote: >>> Modified: head/sys/modules/zfs/Makefile >>> =3D >>> =3D >>> =3D >>> =3D >>> =3D >>> =3D >>> =3D >>> =3D >>> =3D >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- head/sys/modules/zfs/Makefile Tue Jan 31 01:48:55 2017 = (r313004) >>> +++ head/sys/modules/zfs/Makefile Tue Jan 31 01:55:29 2017 = (r313005) >>> @@ -94,7 +94,7 @@ CFLAGS+=3D-I${SUNW}/common >>> CFLAGS+=3D-DBUILDING_ZFS >>>=20 >>> .if ${MACHINE_ARCH} =3D=3D "powerpc64" >>> -CFLAGS+=3D-mminimal-toc >>> +CFLAGS.gcc+=3D-mminimal-toc >>> .endif >>>=20 >>> .ifdef ZFS_DEBUG >>=20 >> You may want to process my bugzilla 215107 with = head/sys/modules/zfs/Makefile >> as it also deals with that -mminimal-toc: in other words to declare = 215107 >> fixed by this update. >>=20 >> =3D=3D=3D >> Mark Millard >> markmi at dsl-only.net >>=20 >=20 > Ah, thanks for reminding me, I'll take that. >=20 > - Justin Thanks. 215947 is sort of related in that it eliminated -mlongcall usage because (A) clang 3.8.0 did not have it and (B) the usage was not needed under the medium model. It also limited the forced use of gcc in: /usr/src/lib/csu/powerpc64/Makefile But I've had the patch in use for a long time and -mlongcall now exists if one requires a recent enough clang. (I only recently made a bugzilla for the issue so bugzilla does not reflect the patch's age.) Even if you leave in the -mlongcall usage something like part of the patch should be applied to avoid forcing gcc use. And the comment about why -mlongcall is needed is now wrong even if the -mlongcall 's are left in place. =3D=3D=3D Mark Millard markmi at dsl-only.net