From owner-freebsd-rc@FreeBSD.ORG  Thu Jun  8 22:20:26 2006
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@hub.freebsd.org
Delivered-To: freebsd-rc@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5526B16A506
	for <freebsd-rc@hub.freebsd.org>; Thu,  8 Jun 2006 22:20:26 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2152E43D48
	for <freebsd-rc@hub.freebsd.org>; Thu,  8 Jun 2006 22:20:26 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k58MKPhr072675
	for <freebsd-rc@freefall.freebsd.org>; Thu, 8 Jun 2006 22:20:25 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k58MKPJh072674;
	Thu, 8 Jun 2006 22:20:25 GMT (envelope-from gnats)
Date: Thu, 8 Jun 2006 22:20:25 GMT
Message-Id: <200606082220.k58MKPJh072674@freefall.freebsd.org>
To: freebsd-rc@FreeBSD.org
From: Doug White <dwhite@gumbysoft.com>
Cc: 
Subject: Re: conf/94377 : [patch] /etc/rc.d/sshd improperly tests random dev
 state
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Doug White <dwhite@gumbysoft.com>
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jun 2006 22:20:26 -0000

The following reply was made to PR conf/94377; it has been noted by GNATS.

From: Doug White <dwhite@gumbysoft.com>
To: Rostislav Krasny <rosti.bsd@gmail.com>
Cc: Florent Thoumie <flz@FreeBSD.org>, bug-followup@FreeBSD.org
Subject: Re: conf/94377 : [patch] /etc/rc.d/sshd improperly tests random dev
 state
Date: Thu, 8 Jun 2006 13:14:04 -0700 (PDT)

 On Thu, 8 Jun 2006, Rostislav Krasny wrote:
 
 > The sysctl will fail because of a wrong variable name, but no syntax
 > error will occur. If you remove the double quotes around the ${seeded}
 > only then a syntaxt error will happen.
 >
 > If on CURRENT it works differently then most likely it has a bug
 > in sh(1).
 
 *shrug* The patch sat idle for 4 months, so you had your chance to say 
 your piece. I don't think doing another merge cycle just to sate a minor 
 stylistic nit is justified. This code runs once any time the rc script is 
 executed, which on most systems is once on boot. Its not like we're trying 
 to shave cycles here.
 
 -- 
 Doug White                    |  FreeBSD: The Power to Serve
 dwhite@gumbysoft.com          |  www.FreeBSD.org