From owner-freebsd-arm@FreeBSD.ORG  Wed Dec 10 23:25:37 2014
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4761DEFC
 for <freebsd-arm@freebsd.org>; Wed, 10 Dec 2014 23:25:37 +0000 (UTC)
Received: from mail-yh0-f46.google.com (mail-yh0-f46.google.com
 [209.85.213.46])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 09F615E0
 for <freebsd-arm@freebsd.org>; Wed, 10 Dec 2014 23:25:36 +0000 (UTC)
Received: by mail-yh0-f46.google.com with SMTP id t59so1780987yho.33
 for <freebsd-arm@freebsd.org>; Wed, 10 Dec 2014 15:25:30 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type
 :content-transfer-encoding;
 bh=e9Z9H9+bJjB+lT5Q2bZvhSEucvmrRHJnKVSwOzG2oLU=;
 b=DPgg+/3k4RLr8wp8Mvlxf5CCeWTZkCOW1e54JPBNUU34VUsgvFQZitmP5VqJJglU4y
 PVnT7dTUHoHU17mYXOkMv+d2fWWwchj5WwZWhI6Njs4pi3ys9Ve/4uV5U+t2+MQtMtVC
 GIbNCciU+scVJAu/1uO+IiAZGh2QpmQQxKG+ePy0gjHiUlk2u+lZ4MSqQJGNS1Zc0dT0
 t+i70i8OVzt8pAl9H8s0Xu1sbIsKmuCqUkTEeq/fVQD0andZweYrzmhm4XXC0FEp6pSt
 F7qAr9YZmyRm1yoOgNm/53Fp1ZNpZSVnpTrI4vR7HFwEPsbNLwPlECKLS7yk9iHIrNqQ
 z1vA==
X-Gm-Message-State: ALoCoQnNmYSNqklAwsxocRFA1du98v9stiP6WniZGDFFf3n9mbeTWKLYOnzS9Aym7+0RFcMwNXdP
MIME-Version: 1.0
X-Received: by 10.170.116.21 with SMTP id i21mr5678449ykb.105.1418253608045;
 Wed, 10 Dec 2014 15:20:08 -0800 (PST)
Received: by 10.170.35.20 with HTTP; Wed, 10 Dec 2014 15:20:07 -0800 (PST)
In-Reply-To: <BE44C51E-DA0C-4871-9D6F-EA0BAEF1F77A@bsdimp.com>
References: <CAG7dG+zAwmysuygugEh1mB767KPw5n1UB1YnotPSCdozcFC_yQ@mail.gmail.com>
 <BE44C51E-DA0C-4871-9D6F-EA0BAEF1F77A@bsdimp.com>
Date: Thu, 11 Dec 2014 00:20:07 +0100
Message-ID: <CAG7dG+zVFOpsW1aLnYV-WMch5=4QwSyv=oQRMJy2PbxsDGOQsw@mail.gmail.com>
Subject: Re: Minor fixes to PL011 UART
From: Zbigniew Bodek <zbb@semihalf.com>
To: Warner Losh <imp@bsdimp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Dec 2014 23:25:37 -0000

2014-12-11 0:10 GMT+01:00 Warner Losh <imp@bsdimp.com>:
>
>> On Dec 10, 2014, at 2:14 PM, Zbigniew Bodek <zbb@semihalf.com> wrote:
>>
>> <0001-Fix-some-obvious-mistakes-in-ARM-PL011-UART.patch>
>
> This looks good to me, assuming that the busy bit you are testing is well=
 defined for all implementations of pl011. I=E2=80=99d consider adding the =
uart_barrier, but it isn=E2=80=99t critical.
>
> Warner

Hello,

Thanks. According to the documentation BUSY bit is common to all
product revisions.

Best regards
zbb