From owner-freebsd-ports@FreeBSD.ORG Wed Oct 31 17:43:17 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F1FC5C55; Wed, 31 Oct 2012 17:43:16 +0000 (UTC) (envelope-from jnagyjr1978@gmail.com) Received: from mail-gh0-f182.google.com (mail-gh0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 85DF98FC16; Wed, 31 Oct 2012 17:43:16 +0000 (UTC) Received: by mail-gh0-f182.google.com with SMTP id r20so337464ghr.13 for ; Wed, 31 Oct 2012 10:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; bh=suUV6wN9ywEd5Bni39iO2TDLIxnii4avopYuq+HDhxQ=; b=qtjtGJzlsmIR5vKvwEPEkOowShtWKPX42t6Xfg5kZcYnZ1FsrC4ULeifvj8xCgfoMy LoVsMVwhNu63oAR7/84ytS0Bp1nYYuE0Uc8Sd8he4qvwtvnvTZEDCEXsuRvJqW2nuHy5 L0LFVzIM/HGCFgPQzKv0IO7fD6UZOuD3pxSkRTbqW8kJ4CHfzT7G707sjq1l1eiShxbm giFBhLZQ878D0r70SSptGSeeDHLNBDqA5egM/XMhZoSlYkw/EpvgDbvDyviawK8voD0e 0fHckPY05vKzVrpvM17vqbwwNcWeqMuc+E83lx3/tZfPdGUdbv8N7fyR09obeYsAgoGt 2dHQ== Received: by 10.236.173.9 with SMTP id u9mr37965810yhl.129.1351705390163; Wed, 31 Oct 2012 10:43:10 -0700 (PDT) Received: from alex-laptop. (vid-196.dhcp.grp10.tnmmrl.infoave.net. [204.116.254.196]) by mx.google.com with ESMTPS id z28sm4286012yhh.7.2012.10.31.10.43.07 (version=SSLv3 cipher=OTHER); Wed, 31 Oct 2012 10:43:09 -0700 (PDT) Message-ID: <509162C9.9060701@gmail.com> Date: Wed, 31 Oct 2012 12:41:29 -0500 From: Joseph a Nagy Jr User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:16.0) Gecko/20121022 Thunderbird/16.0.1 MIME-Version: 1.0 To: gahr@FreeBSD.org Subject: Re: tk85 Port Maintenance References: <509121B3.3040307@gmail.com> <20121031135749.GC90275@gahrfit.gahr.ch> <50913253.3060700@gmail.com> <20121031152109.GD90275@gahrfit.gahr.ch> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> In-Reply-To: <20121031165507.GF90275@gahrfit.gahr.ch> X-Enigmail-Version: 1.4.5 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4D9A4F2BA43CAF606B552EB4" X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: ports@freebsd.org, Chris Rees X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2012 17:43:17 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4D9A4F2BA43CAF606B552EB4 Content-Type: multipart/mixed; boundary="------------080600030401020608050702" This is a multi-part message in MIME format. --------------080600030401020608050702 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/31/12 11:55, Pietro Cerutti wrote: > On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: >> New diff[0], undoing some of the earlier changes even though portlint >> complains: >> >> portlint ~/port-maintenance/tk85/ >> WARN: Makefile: unless this is a master port, COMMENT has to be set by= >> "=3D", not by "?=3D". >=20 > This *is* a master port, so it's ok to have COMMENT?=3D >=20 >> WARN: Makefile: "LIB_DEPENDS" has to appear earlier. >=20 > This should be fixed as portlint suggests. >=20 >> WARN: Makefile: no port directory >> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is >> listed in LIB_DEPENDS. >=20 > I would try and use USE_TCL instead of LIB_DEPENDS here >=20 >> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in= >> Xft.2 unless it is really necessary. >=20 > This should be fixed as portlint suggests. >=20 >> 0 fatal errors and 4 warnings found. >> >> [0]: http://pastebin.com/apf1Y9H0 >=20 > I'll have a look at it on Friday, thanks! >=20 >=20 Going ahead to make those changes, old pastebin link is defunct. New diff with all changes: http://pastebin.com/iwhpXfcp --=20 Yours in Christ, Joseph A Nagy Jr "Whoever loves instruction loves knowledge, But he who hates correction is stupid." -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org --------------080600030401020608050702-- --------------enig4D9A4F2BA43CAF606B552EB4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQkWLKAAoJECqR4kIlFcuBN6UIAKMAneFnWTXgdLZpXB+X2Kbm k/bwdHTCdW+53T4zjtKlNYye9dDQjO3QaVSLU39jfE+q9AKh7mFlzUj3eEOgov2/ fuMWpQoD6fs+rbwPxOQDGzarl2S+xz3x1vzhXtl13pXQfg2aZO1rkYNhw6y5RRgn 126E+CIZ1eHSySsQj3+wqL0EzZmBeQqqI6M3CqTlBSVWEAKQAthglNhnbY6VJ6L+ cLcR/QkducftIbkOX/eSJMZ+XqXWCw5MbfE9QIkwnEYTpseSinsUN034SxGm6+Ny Ye7o5DOU6njU0ocCcgVKgsLiUVGZsCKj0X6cFfQcTkiAX/lxHXEbSOBbqkAxe2E= =iQ39 -----END PGP SIGNATURE----- --------------enig4D9A4F2BA43CAF606B552EB4--