From owner-svn-src-head@FreeBSD.ORG Thu May 7 19:48:31 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D25C510656F7; Thu, 7 May 2009 19:48:31 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.29]) by mx1.freebsd.org (Postfix) with ESMTP id 548948FC26; Thu, 7 May 2009 19:48:31 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: by yx-out-2324.google.com with SMTP id 8so574266yxb.13 for ; Thu, 07 May 2009 12:48:30 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.90.66.14 with SMTP id o14mr1359631aga.10.1241725710629; Thu, 07 May 2009 12:48:30 -0700 (PDT) In-Reply-To: <200905071946.n47JkTmQ066266@svn.freebsd.org> References: <200905071946.n47JkTmQ066266@svn.freebsd.org> From: Juli Mallett Date: Thu, 7 May 2009 12:48:10 -0700 X-Google-Sender-Auth: f970ee702ea1c869 Message-ID: To: Jamie Gritton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191898 - head/sys/compat/linux X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2009 19:48:32 -0000 Worth remembering: the difference is not just that their sizes may (often do) differ. size_t is unsigned. ssize_t is signed. An unqualified int is signed. On Thu, May 7, 2009 at 12:46 PM, Jamie Gritton wrote: > Author: jamie > Date: Thu May =A07 19:46:29 2009 > New Revision: 191898 > URL: http://svn.freebsd.org/changeset/base/191898 > > Log: > =A0Give vfs_getopt the type it's expecting. > =A0Write 100 times: "32 bits is so twentieth century." > > =A0Noticed by: =A0 dchagin > > Modified: > =A0head/sys/compat/linux/linux_mib.c > > Modified: head/sys/compat/linux/linux_mib.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/compat/linux/linux_mib.c =A0 Thu May =A07 19:17:06 2009 =A0 = =A0 =A0 =A0(r191897) > +++ head/sys/compat/linux/linux_mib.c =A0 Thu May =A07 19:46:29 2009 =A0 = =A0 =A0 =A0(r191898) > @@ -223,8 +223,7 @@ linux_prison_check(void *obj __unused, v > =A0{ > =A0 =A0 =A0 =A0struct vfsoptlist *opts =3D data; > =A0 =A0 =A0 =A0char *osname, *osrelease; > - =A0 =A0 =A0 size_t len; > - =A0 =A0 =A0 int error, oss_version; > + =A0 =A0 =A0 int error, len, oss_version; > > =A0 =A0 =A0 =A0/* Check that the parameters are correct. */ > =A0 =A0 =A0 =A0(void)vfs_flagopt(opts, "linux", NULL, 0); > @@ -263,8 +262,7 @@ linux_prison_set(void *obj, void *data) > =A0 =A0 =A0 =A0struct prison *pr =3D obj; > =A0 =A0 =A0 =A0struct vfsoptlist *opts =3D data; > =A0 =A0 =A0 =A0char *osname, *osrelease; > - =A0 =A0 =A0 size_t len; > - =A0 =A0 =A0 int error, gotversion, nolinux, oss_version, yeslinux; > + =A0 =A0 =A0 int error, gotversion, len, nolinux, oss_version, yeslinux; > > =A0 =A0 =A0 =A0/* Set the parameters, which should be correct. */ > =A0 =A0 =A0 =A0yeslinux =3D vfs_flagopt(opts, "linux", NULL, 0); >