From owner-svn-src-head@FreeBSD.ORG  Mon Nov 15 15:32:15 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CC44C106566C;
	Mon, 15 Nov 2010 15:32:15 +0000 (UTC) (envelope-from zec@icir.org)
Received: from munja.zvne.fer.hr (munja.zvne.fer.hr [161.53.66.248])
	by mx1.freebsd.org (Postfix) with ESMTP id 5BE168FC0C;
	Mon, 15 Nov 2010 15:32:14 +0000 (UTC)
Received: from sluga.fer.hr ([161.53.66.244]) by munja.zvne.fer.hr with
	Microsoft SMTPSVC(6.0.3790.4675); Mon, 15 Nov 2010 16:20:10 +0100
Received: from localhost ([161.53.19.8]) by sluga.fer.hr with Microsoft
	SMTPSVC(6.0.3790.4675); Mon, 15 Nov 2010 16:20:09 +0100
From: Marko Zec <zec@icir.org>
To: "Bjoern A. Zeeb" <bz@freebsd.org>
Date: Mon, 15 Nov 2010 16:19:36 +0100
User-Agent: KMail/1.9.10
References: <201011142040.oAEKetST093270@svn.freebsd.org>
	<20101115145153.C24596@maildrop.int.zabbadoz.net>
In-Reply-To: <20101115145153.C24596@maildrop.int.zabbadoz.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <201011151619.37758.zec@icir.org>
X-OriginalArrivalTime: 15 Nov 2010 15:20:10.0654 (UTC)
	FILETIME=[97E7BBE0:01CB84D8]
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org>
Subject: Re: svn commit: r215318 - in head/sys: net sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Nov 2010 15:32:15 -0000

On Monday 15 November 2010 15:58:15 Bjoern A. Zeeb wrote:
> On Sun, 14 Nov 2010, Dimitry Andric wrote:
> > Author: dim
> > Date: Sun Nov 14 20:40:55 2010
> > New Revision: 215318
> > URL: http://svn.freebsd.org/changeset/base/215318
> >
> > Log:
> >  Instead of unconditionally emitting .globl's for the __start_set_xxx and
> >  __stop_set_xxx symbols, only emit them when the set_vnet or set_pcpu
> >  sections are actually defined.
>
> Unless you have a very good reason that is NOT cosmetic for this I
> want to know it. None of you commit messages is giving this.
>
> This breaks the classic C semantics that we had gained with the former
> type of macros, which is a shame.
>
> Kind of annoying neither of the changes had a Reviewed by: and despite
> being about 2 weeks behind of most email I hadn't spotted this on arch@
> before nor seen it on virtualization@ that it obviously touches.  I
> would have loved to hear about them before foing to have a hard time
> integrating this white space into half a year of development work.
>
> Looking forward to the technical explanation.

Another fundamental problem is that the commit note doesn't include a MFC 
plan, so if we just leave it as is, starting from now on an extremely large 
portion MFCs of networking code will need to be hand-adjusted.

Marko


> > Modified:
> >  head/sys/net/vnet.h
> >  head/sys/sys/cdefs.h
> >  head/sys/sys/linker_set.h
> >  head/sys/sys/pcpu.h