From owner-freebsd-current@FreeBSD.ORG Sun Dec 21 05:33:53 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9EDEF1065674; Sun, 21 Dec 2008 05:33:53 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.131.111.2]) by mx1.freebsd.org (Postfix) with ESMTP id 5D42F8FC26; Sun, 21 Dec 2008 05:33:53 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from acrux.dbai.tuwien.ac.at (acrux [128.131.111.60]) by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP id 641BC3910F; Sun, 21 Dec 2008 06:01:28 +0100 (CET) Received: by acrux.dbai.tuwien.ac.at (Postfix, from userid 1203) id C70BD10059; Sun, 21 Dec 2008 06:01:35 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by acrux.dbai.tuwien.ac.at (Postfix) with ESMTP id AA07310055; Sun, 21 Dec 2008 06:01:35 +0100 (CET) Date: Sun, 21 Dec 2008 06:01:35 +0100 (CET) From: Gerald Pfeifer To: Vladimir Grebenschikov In-Reply-To: <1229691231.1818.53.camel@localhost> Message-ID: References: <200812150634.mBF6YDVC060565@freefall.freebsd.org> <873agpk11i.fsf@kobe.laptop> <1229691231.1818.53.camel@localhost> User-Agent: Alpine 1.99 (LSU 1142 2008-08-13) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Mailman-Approved-At: Sun, 21 Dec 2008 12:05:37 +0000 Cc: Qing Li , freebsd-current@freebsd.org, freebsd-net@freebsd.org Subject: Re: HEADSUP: arp-v2 has been committed X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Dec 2008 05:33:53 -0000 The code in question on the Wine side is #if defined(HAVE_SYS_SYSCTL_H) && defined(NET_RT_DUMP) int mib[] = {CTL_NET, PF_ROUTE, 0, AF_INET, NET_RT_FLAGS, RTF_LLINFO}; and there is nothing FreeBSD-specific in dlls/iphlpapi/ipstats.c as far as I can see. If the arp-v2 update now made us incompatible both with earlier versions of FreeBSD and Linux, that sounds like something that should be fixed (instead of hacking applications like Wine). On the other hand, the commit message at http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/net/route.h explicitly says The change in design obsoletes the semantics of RTF_CLONING, RTF_WASCLONE and RTF_LLINFO routing flags. The userland applications such as "arp" and "ndp" have been modified to reflect those changes. so I guess it's not so easy. How many other ports are affected? What shall we do on the Wine front? Simply #ifdef-ing out the code in question may not be the best of ideas, either. :-( Gerald On Fri, 19 Dec 2008, Vladimir Grebenschikov wrote: > On Mon, 15 Dec 2008 06:34:13 GMT, Qing Li wrote: > >>> The arp-v2 changes have been committed into HEAD. >>> Please report problems to me and Kip Macy. > > Wine is not build any more: > > ... > cc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -I/usr/local/include -O2 -pipe -fno-strict-aliasing -o ipstats.o ipstats.c > ipstats.c: In function 'getNumArpEntries': > ipstats.c:1253: error: 'RTF_LLINFO' undeclared (first use in this function) > ipstats.c:1253: error: (Each undeclared identifier is reported only once > ipstats.c:1253: error: for each function it appears in.) > ipstats.c: In function 'getArpTable': > ipstats.c:1311: error: 'RTF_LLINFO' undeclared (first use in this function) > ipstats.c:1311: warning: initialization makes integer from pointer without a cast > gmake[2]: *** [ipstats.o] ?????? 1 > gmake[2]: Leaving directory `/usr/ports/emulators/wine/work/wine-1.1.10/dlls/iphlpapi' > gmake[1]: *** [iphlpapi] ?????? 2 > gmake[1]: Leaving directory `/usr/ports/emulators/wine/work/wine-1.1.10/dlls' > gmake: *** [dlls] ?????? 2 > > -- Gerald (Jerry) Pfeifer gerald@pfeifer.com http://www.pfeifer.com/gerald/