From owner-freebsd-threads@freebsd.org Thu Dec 24 14:29:51 2015 Return-Path: Delivered-To: freebsd-threads@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79E04A51ADC for ; Thu, 24 Dec 2015 14:29:51 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 669CD1948 for ; Thu, 24 Dec 2015 14:29:51 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 6591AA51ADB; Thu, 24 Dec 2015 14:29:51 +0000 (UTC) Delivered-To: threads@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64F97A51AD9; Thu, 24 Dec 2015 14:29:51 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.netplex.net", Issuer "RapidSSL SHA256 CA - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 304F91947; Thu, 24 Dec 2015 14:29:50 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.15.1/8.15.1/NETPLEX) with ESMTP id tBOETneO001930; Thu, 24 Dec 2015 09:29:49 -0500 X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-4.4.3 (mail.netplex.net [204.213.176.9]); Thu, 24 Dec 2015 09:29:49 -0500 (EST) Date: Thu, 24 Dec 2015 09:29:49 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net Reply-To: Daniel Eischen To: John Baldwin cc: freebsd-arch@freebsd.org, Konstantin Belousov , threads@freebsd.org, arch@freebsd.org Subject: Re: libthr shared locks In-Reply-To: <4199356.DlQeWDh27F@ralph.baldwin.cx> Message-ID: References: <20151223172528.GT3625@kib.kiev.ua> <20151223201837.GW3625@kib.kiev.ua> <4199356.DlQeWDh27F@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 14:29:51 -0000 On Wed, 23 Dec 2015, John Baldwin wrote: > On Wednesday, December 23, 2015 10:18:37 PM Konstantin Belousov wrote: [ much snipped for brevity ] >> >> It is not feasible to do a reliable audit of the 24+ Kports. > > As a bit of a devil's advocate, I think the 64-bit ino_t change will in > fact require this for 11. I suspect 3rd pary apps embed struct stat in > various structures as well and that that ABI change will require not > mixing old and new libraries. > > One other point in favor of Konstantin's approach (IMO) is that keeping > the structures private prevents having to maintain the ABI of those > structures in the future. I'm already keenly aware of how painful a > problem that can be with our non-opaque FILE (and which we cannot now > make opaque even though the standard APIs would work fine with an opaque > object). This seems to be David's latest patch: http://people.freebsd.org/~davidxu/patch/pshared0607.diff It is only 3 years old (2012). I have email from David that says he got 8-10% speedup in mysql OLTP from making the synch types structures. The patch also implements robust and priority inheritence mutexes bumps shared library versions. -- DE