From owner-svn-src-all@freebsd.org Mon Dec 5 21:50:03 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24739C68485; Mon, 5 Dec 2016 21:50:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 038D515DF; Mon, 5 Dec 2016 21:50:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 692A210AA59; Mon, 5 Dec 2016 16:50:01 -0500 (EST) From: John Baldwin To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r308371 - in stable/10: share/man/man4 sys/conf sys/dev/jedec_ts sys/modules/i2c sys/modules/i2c/jedec_ts Date: Mon, 05 Dec 2016 13:49:50 -0800 Message-ID: <1625245.4edrXav981@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: <201611061356.uA6DuYcO079294@repo.freebsd.org> References: <201611061356.uA6DuYcO079294@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 05 Dec 2016 16:50:01 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 21:50:03 -0000 On Sunday, November 06, 2016 01:56:34 PM Andriy Gapon wrote: > Author: avg > Date: Sun Nov 6 13:56:34 2016 > New Revision: 308371 > URL: https://svnweb.freebsd.org/changeset/base/308371 > > Log: > MFC r307768: jedec_ts: a driver for thermal sensors on memory modules > > Added: > stable/10/share/man/man4/jedec_ts.4 > - copied unchanged from r307768, head/share/man/man4/jedec_ts.4 > stable/10/sys/dev/jedec_ts/ > - copied from r307768, head/sys/dev/jedec_ts/ > stable/10/sys/modules/i2c/jedec_ts/ > - copied from r307768, head/sys/modules/i2c/jedec_ts/ > Modified: > stable/10/sys/conf/NOTES > stable/10/sys/conf/files > stable/10/sys/modules/i2c/Makefile > Directory Properties: > stable/10/ (props changed) FYI, this doesn't work and has broken tinderbox builds on stable/10. smbus_get_addr() doesn't exist on 10. It was originally a hand-rolled ivar wrapper that was removed in r93023 in 2002. The function prototype was not removed, so the compile works, but linking fails. The stale prototype is still present in smbconf.h in HEAD (and should be removed). The "real" smbus_get_addr() was added back to smbconf.h along with an implementation of smbus_read_ivar() in r281985. Parts of that commit probably need to be MFC'd to 10. -- John Baldwin