Date: Tue, 03 Jan 2017 03:21:26 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: jbeich@freebsd.org Cc: starikarp@yandex.com, ports@freebsd.org Subject: Re: libwraster Message-ID: <20170103.032126.1717605790407508097.hrs@allbsd.org> In-Reply-To: <20170101195127.6C0CB3FBF@freefall.freebsd.org> References: <20170102.032931.2199837842430250667.hrs@allbsd.org> <20170101195127.6C0CB3FBF@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart0(Tue_Jan__3_03_21_26_2017_988)-- Content-Type: Multipart/Mixed; boundary="--Next_Part(Tue_Jan__3_03_21_26_2017_167)--" Content-Transfer-Encoding: 7bit ----Next_Part(Tue_Jan__3_03_21_26_2017_167)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit jbeich@freebsd.org (Jan Beich) wrote in <20170101195127.6C0CB3FBF@freefall.freebsd.org>: jb> Hiroki Sato <hrs@FreeBSD.org> writes: jb> jb> > I did not able to reproduce it even if ImageMagick was built with the jb> > OpenMP option. I guess your environment has another issue which jb> > pulls -lomp into the build process. jb> jb> Clang >= 3.7 no longer ignores -fopenmp which now requires libomp.so jb> from devel/openmp (for base compiler) or devel/llvm* built with OPENMP=on. jb> jb> For example: jb> 1. Use FreeBSD >= 11.0 jb> 2. Install graphics/ImageMagick with OPENMP=on jb> 3. Deinstall devel/openmp (just in case) jb> 4. Build the port with default compiler jb> jb> The obvious fix is teach ImageMagick to not pollute namespace as nothing jb> in its public API uses #pragma omp or omp_ symbols. So is the attached patch safe to avoid this? -- Hiroki ----Next_Part(Tue_Jan__3_03_21_26_2017_167)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ImageMagick.20170103-1.diff" Index: graphics/ImageMagick/files/patch-configure =================================================================== --- graphics/ImageMagick/files/patch-configure (nonexistent) +++ graphics/ImageMagick/files/patch-configure (working copy) @@ -0,0 +1,10 @@ +--- configure.orig 2017-01-03 02:07:28.432298000 +0900 ++++ configure 2017-01-03 02:09:38.248392000 +0900 +@@ -11691,7 +11691,6 @@ + + + CFLAGS="$OPENMP_CFLAGS $CFLAGS" +-MAGICK_PCFLAGS="$MAGICK_PCFLAGS $OPENMP_CFLAGS" + + if test "$enable_openmp" != no; then + if test "$ac_cv_prog_c_openmp" != 'unsupported'; then Property changes on: graphics/ImageMagick/files/patch-configure ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property ----Next_Part(Tue_Jan__3_03_21_26_2017_167)---- ----Security_Multipart0(Tue_Jan__3_03_21_26_2017_988)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlhqmiYACgkQTyzT2CeTzy3/UQCgkTRnZuIt/Do1PJkE1b7O4W5V WCsAnRuIjrQZpOHUIwuIDEjlncuMcmoz =CIwR -----END PGP SIGNATURE----- ----Security_Multipart0(Tue_Jan__3_03_21_26_2017_988)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170103.032126.1717605790407508097.hrs>