From owner-freebsd-hackers  Sat Jan  7 15:13:30 1995
Return-Path: hackers-owner
Received: (from root@localhost) by freefall.cdrom.com (8.6.9/8.6.6) id PAA29882 for hackers-outgoing; Sat, 7 Jan 1995 15:13:30 -0800
Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.9/8.6.6) with ESMTP id PAA29876 for <freebsd-hackers@freefall.cdrom.com>; Sat, 7 Jan 1995 15:13:29 -0800
Received: from localhost (localhost [127.0.0.1]) by time.cdrom.com (8.6.9/8.6.9) with SMTP id PAA29509; Sat, 7 Jan 1995 15:12:59 -0800
X-Authentication-Warning: time.cdrom.com: Host localhost didn't use HELO protocol
To: Peter Dufault <dufault@hda.com>
cc: freebsd-hackers@freefall.cdrom.com
Subject: Re: Commit testing 
In-reply-to: Your message of "Sat, 07 Jan 95 12:26:07 EST."
             <199501071726.MAA08014@hda.com> 
Date: Sat, 07 Jan 1995 15:12:59 -0800
Message-ID: <29508.789520379@time.cdrom.com>
From: "Jordan K. Hubbard" <jkh@time.cdrom.com>
Sender: hackers-owner@FreeBSD.org
Precedence: bulk

> How do committers test things?  I want to commit changes to
> sys/scsi/* and sys/i386/isa/aha1542.c.  (the diffs, if you want to
> see them, are on freefall in pub:incoming/sutar7.gz) How do you
> handle the time between when you've thoroughly tested something
> and you then check it into -current?  By hoping and watching commit
> logs?

Mostly we just bring them onto our own systems, watch them for awhile,
then if nothing too horrible happens, we commit into the master tree.
Nothing more complex than that, I'm afraid..

> And does anyone review changes before they are commited, and
> what is that process?

Some developers, like David and John, review eachothers work but this
is just a private arrangement.  You are, of course, always encouraged
to make similar arrangements! :-)

						Jordan