From owner-svn-ports-all@freebsd.org  Mon Jul 16 10:57:53 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E11B104A98D;
 Mon, 16 Jul 2018 10:57:53 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B60148B149;
 Mon, 16 Jul 2018 10:57:52 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id ADE521A7E1; Mon, 16 Jul 2018 10:57:52 +0000 (UTC)
Date: Mon, 16 Jul 2018 10:57:52 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: Gerald Pfeifer <gerald@pfeifer.com>,
 Dmitry Marakasov <amdmi3@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r470444 - head/lang/gcc-ecj45
Message-ID: <20180716105752.GA69746@FreeBSD.org>
References: <201805200904.w4K94BAh007929@repo.freebsd.org>
 <alpine.LSU.2.21.1807142237341.5444@anthias.pfeifer.com>
 <20180716094530.k6ls4yddh2nmlivd@ogg.in.absolight.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180716094530.k6ls4yddh2nmlivd@ogg.in.absolight.net>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jul 2018 10:57:53 -0000

On Mon, Jul 16, 2018 at 11:45:30AM +0200, Mathieu Arnold wrote:
> On Sat, Jul 14, 2018 at 10:39:11PM +0200, Gerald Pfeifer wrote:
> > I'm not really sure "cosmetic fixes" are covered by portmgr
> > blanket, especially where something is a style issue.
> > 
> > > -EXTRACT_SUFX=
> > > -EXTRACT_ONLY=
> > > +EXTRACT_SUFX=	# empty
> > > +EXTRACT_ONLY=	# empty
> > 
> > ...I preferred the original version of that and do not see this
> > as a real improvement.
> 
> There is some kind of, mmmm, style police that, I think, believe
> variables must have a value

No, it's not about that variables must have a value, it's to designate
that it was made empty on purpose, it's not a stray line or some editor
glitch.  Kind of like why people write "while (...) continue;" rather
than simply "while (...);".  The former clearly shows the intentions,
the latter could be just a stupid bug.

> Never understood it myself.

Hope now it is more clear for you. :-)

./danfe