From owner-svn-src-stable-10@freebsd.org Thu Jan 14 12:37:33 2016 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4584A81CE1 for ; Thu, 14 Jan 2016 12:37:33 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 23D3C1FB9 for ; Thu, 14 Jan 2016 12:37:33 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x229.google.com with SMTP id f206so343592461wmf.0 for ; Thu, 14 Jan 2016 04:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=j0+wgGUiMlsy7ag55gZzS3bLt02WzO7iumeBNB2Y6pg=; b=wpzaRN6HchPgiPage1Rzfz0KAQWNX0GFDLJU07EpxuztnN2dCaX+3FQwBQFTdhwJdA OBJTmBp0QzbA0QaTIa9E5YiEia3QRIrWWWAuFNEo3ovNJCDi39YAL2hDHhtcRbXfz8QT xf6ADhxfPiWXHetFzyanzZEkvNHlbc7V4xeQhsWwT6qLE3gRc8Uw7uYQxfrELTSSqLcg U/qSsnYv9K1vsDDVFVSDDl82ihWZ2yYty1BIp+lJQ2P3jgIPSpiVvUfUBSt3HE6ifoXK XuSrvm3EG6B0WD0mP2rpospkdc1HAaOYocpf0rZ6hdugVOGvlq+aDx708kvW9J38jYTI XK7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=j0+wgGUiMlsy7ag55gZzS3bLt02WzO7iumeBNB2Y6pg=; b=eGUmPQE5w7gdycvqkzZBy2A5iTrHjbflEDjkRBDtpC+1N8n1Kp43cEOhIlNSx4gNhA cfgknVKN9LeU742uJseZJy3cNQedHmE7rw8dt/23W1iLu7W63U5DuhIhjR/dmW0CHXP1 M9etujA8rcns2Xbq7DkPoVlk3PcYWKhGvOf+NDFytxY+QVhvpJj2Tef3uCr1aveFLTuL az5+wUXRhVdbh+FTzKLNy9d6qKhZazhhoQnboZCrJ++/2zyVDFADnm/9NAzEyf6WZFn/ Tgz4Y+a+W1q6ucABUtCysS/slGnP/j/GzUxOm5COeyhOI9F9tnF6k1jBGPLLiwGDGx5t xAuQ== X-Gm-Message-State: ALoCoQlvvS12faWLdbpuB/smkZsTE1vXs1NT0AkLeqfMaczzx/iQGJm0YqDOJ7MOJw0Gao3a5Ll5x9J+zJtOeD63HbUomd/hg/PAbuD5GrKeLDT21kcYduw= MIME-Version: 1.0 X-Received: by 10.28.228.87 with SMTP id b84mr30501769wmh.81.1452775051644; Thu, 14 Jan 2016 04:37:31 -0800 (PST) Received: by 10.194.85.167 with HTTP; Thu, 14 Jan 2016 04:37:31 -0800 (PST) In-Reply-To: References: <201601140142.u0E1gAFE089373@repo.freebsd.org> Date: Thu, 14 Jan 2016 13:37:31 +0100 Message-ID: Subject: Re: svn commit: r293865 - stable/10/usr.sbin/sesutil From: Oliver Pinter To: Allan Jude Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 12:37:33 -0000 On 1/14/16, Oliver Pinter wrote: > On 1/14/16, Allan Jude wrote: >> Author: allanjude >> Date: Thu Jan 14 01:42:09 2016 >> New Revision: 293865 >> URL: https://svnweb.freebsd.org/changeset/base/293865 >> >> Log: >> MFC: r287473 >> Add the new sesutil(8) utility for managing SCSI Enclosure Services >> (SES) device. >> >> MFC: r287493 >> Fix iteration bug >> >> MFC: r287485, r287494, r287992 >> Please the angry gcc 4.2 gods >> >> MFC: r287988 >> Improve and expand sesutil(8) >> >> Return an error if no matching device is found >> Locate can address a slot, in addition to a drive >> Added fault, similar to locate but blinks a different LED >> Added the map command, lists all devices connected to the SES >> controller >> Added the status command, overall status of the SES controller >> >> MFC: r292092 >> sesutil: fix map not printing the status of the LED device in an >> array >> >> MFC: r292093 >> sesutil: pass the correct element type when printing the SES map >> >> MFC: r292121 >> sesutil: Add extra information specific to some SES devices to >> sesutil >> map >> >> MFC: r292122 >> Fix sesutil locate when a sesid is passed to locate command >> >> MFC: r292262 >> Show the enclosure name and id in sesutil map >> >> Relnotes: yes >> Sponsored by: Gandi.net >> Sponsored by: ScaleEngine Inc. >> >> Added: >> stable/10/usr.sbin/sesutil/eltsub.c >> - copied, changed from r287988, head/usr.sbin/sesutil/eltsub.c >> stable/10/usr.sbin/sesutil/eltsub.h >> - copied, changed from r287988, head/usr.sbin/sesutil/eltsub.h >> Modified: >> stable/10/usr.sbin/sesutil/Makefile >> stable/10/usr.sbin/sesutil/sesutil.8 >> stable/10/usr.sbin/sesutil/sesutil.c >> Directory Properties: >> stable/10/ (props changed) >> >> Modified: stable/10/usr.sbin/sesutil/Makefile > > This commit breaks the build on 10-STABLE:: > > --- rescue.all__D --- > sh_stub.c:1:66: warning: implicit declaration of function 'main' is > invalid in C99 [-Wimplicit-function-declaration] > int _crunched_sh_stub(int argc, char **argv, char **envp){return > main(argc,argv,envp);} > ^ > --- usr.sbin.all__D --- > --- all_subdir_sesutil --- > sesutil.o: In function `objmap': > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/sesutil.c:(.text+0x561): > undefined reference to `sbuf_len' > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/sesutil.c:(.text+0x56e): > undefined reference to `sbuf_data' > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/sesutil.c:(.text+0x588): > undefined reference to `sbuf_delete' > eltsub.o: In function `stat2sbuf': > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x4db): > undefined reference to `sbuf_new' > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x4fd): > undefined reference to `sbuf_printf' > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x513): > undefined reference to `sbuf_printf' > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x529): > undefined reference to `sbuf_printf' > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x587): > undefined reference to `sbuf_printf' > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x5a5): > undefined reference to `sbuf_printf' > eltsub.o:/jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x5bc): > more undefined references to `sbuf_printf' follow > eltsub.o: In function `stat2sbuf': > /jenkins/workspace/HardenedBSD-10-STABLE-amd64/usr.sbin/sesutil/eltsub.c:(.text+0x5e6): > undefined reference to `sbuf_finish' > --- secure.all__D --- > > More info about the error: > http://jenkins.hardenedbsd.org:8180/jenkins/job/HardenedBSD-10-STABLE-amd64/lastFailedBuild/console Ahh, sorry, I missed your r293876 commit, which would fix the issue. [...]