From owner-svn-src-all@freebsd.org Tue Oct 27 16:43:03 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 984ED454040; Tue, 27 Oct 2020 16:43:03 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLHZG64PZz3bGs; Tue, 27 Oct 2020 16:43:02 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ej1-f66.google.com with SMTP id p5so3206560ejj.2; Tue, 27 Oct 2020 09:43:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sPt1qA3BqfNjVXLCFMzkg+LcIb8sLXrSTErzb+JWvyQ=; b=JD+p7S7En9z+yxYLxz076rZcARiwka6L9nZDUHZspiNvqfV0bfFOsVXP27S9RwdsC9 94tT3HXuJuQKj2MEONaifBtwb/C++lVEima47ANV15mBHNYs6b+1W7sgNTYVT1zL3UCq h0fLIbP13GdEl3+HOrkFrX2iTELWtwDQWGz2VbPSnXJJCkffC1NPPGficPWEFuKJyLCa iWw7snZokH1iwtj9s/Gfm6o02iFC4wP2lbNUom4AqUXW5WAf0aZ30BXEkugeE2v3ZXii wY1yUkTapuel2v4jtM4BwMBnxYzYIYZyksDS6x0qGl223zdVD8+DvYAW5ZdTSGlJK7eG APwQ== X-Gm-Message-State: AOAM53068exTDEK3MecjA0HVwzN9PbPF3ksxayB5bimtJikoEqzbhCOC 9XLD15H747W1yxREgmmfiZCgYNS6znVlbw== X-Google-Smtp-Source: ABdhPJwa8wsexn8PA3i+A81OUXT8ruAdVD6tM1nsJ3/hu09rZdIsA9keDacESORblfrGmAhp/nTT0A== X-Received: by 2002:a17:906:9588:: with SMTP id r8mr3345500ejx.389.1603816981268; Tue, 27 Oct 2020 09:43:01 -0700 (PDT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id e19sm1394473ejz.35.2020.10.27.09.43.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 09:43:00 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id n15so2695365wrq.2; Tue, 27 Oct 2020 09:43:00 -0700 (PDT) X-Received: by 2002:adf:a51d:: with SMTP id i29mr3959038wrb.409.1603816980640; Tue, 27 Oct 2020 09:43:00 -0700 (PDT) MIME-Version: 1.0 References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> In-Reply-To: <20201024125206.GB38000@FreeBSD.org> From: Alexander Richardson Date: Tue, 27 Oct 2020 16:42:49 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r366993 - head/sys/net To: Alexey Dokuchaev Cc: Hans Petter Selasky , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CLHZG64PZz3bGs X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of arichardsonkde@gmail.com designates 209.85.218.66 as permitted sender) smtp.mailfrom=arichardsonkde@gmail.com X-Spamd-Result: default: False [-2.07 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[209.85.218.66:from]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-0.94)[-0.940]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-0.95)[-0.947]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.19)[-0.188]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.66:from]; FORGED_SENDER(0.30)[arichardson@freebsd.org,arichardsonkde@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[arichardson@freebsd.org,arichardsonkde@gmail.com]; TAGGED_FROM(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 16:43:03 -0000 On Sat, 24 Oct 2020 at 13:52, Alexey Dokuchaev wrote: > > On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote: > > New Revision: 366993 > > URL: https://svnweb.freebsd.org/changeset/base/366993 > > > > Log: > > Run code through "clang-format -style=file" with some additional fixes. > > No functional change. > > > > ... > > @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr, > > > > #ifdef INET6 > > static inline void > > -infiniband_ipv6_multicast_map(const struct in6_addr *addr, > > - const uint8_t *broadcast, uint8_t *buf) > > +infiniband_ipv6_multicast_map( > > + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t *buf) > > { > > This is not how we format these in FreeBSD, please revert. It was correct > before and no "fix" is need here. > > ./danfe Unfortunately this is a limitation of the current clang-format version. I've submitted a patch upstream as https://reviews.llvm.org/D90246 and the config file change is https://reviews.freebsd.org/D26978. Alex