From owner-freebsd-numerics@freebsd.org Fri Sep 6 20:24:05 2019 Return-Path: Delivered-To: freebsd-numerics@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 54111D637C for ; Fri, 6 Sep 2019 20:24:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46Q8Cn1fl1z4rSc for ; Fri, 6 Sep 2019 20:24:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 36F3BD637B; Fri, 6 Sep 2019 20:24:05 +0000 (UTC) Delivered-To: numerics@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 36B4AD6379 for ; Fri, 6 Sep 2019 20:24:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Q8Cn0f2Yz4rSY for ; Fri, 6 Sep 2019 20:24:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EEDDC224D0 for ; Fri, 6 Sep 2019 20:24:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x86KO4hB082679 for ; Fri, 6 Sep 2019 20:24:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x86KO4f0082678 for numerics@FreeBSD.org; Fri, 6 Sep 2019 20:24:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: numerics@FreeBSD.org Subject: [Bug 240295] math(3): Add Complex Arithmetic functions and their hyperbolic counterparts Date: Fri, 06 Sep 2019 20:24:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: standards X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: feature, needs-qa, patch, standards X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kargl@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: numerics@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2019 20:24:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240295 --- Comment #9 from Steve Kargl --- (In reply to Gordon Bergling from comment #8) > > I hope this was good for you, and you were able to direct all your anger, > fear and uncertainty towards this problem report. > > For my perspective, I just saw at [1] that there is an unresolved > issue with FreeBSD's math(3) implementation and I thought, that > this could be solved by stepping a few steps backwards and looking > at what the other BSDs have done to overcome that issue. There is no anger, fear, or uncertainty in my response. More likely disillusionment in that it seems that you=20 have made no effort to review the freebsd-numerics mailing list archive or what libm currently has implemented. Why does your patch have float complex and double complex versions of the functions? FreeBSD's libm has had those since 2011. ccos() already implement in src/s_ccosh.c * Copyright (c) 2005 Bruce D. Evans and Steven G. Kargl ccosf() already implement in src/s_ccoshf.c * Copyright (c) 2005 Bruce D. Evans and Steven G. Kargl (Yes, the Copyright year is correct as it is likely that some code came from other files hwne ccos and ccosf > The tickets I mentioned within my original ticket were open > for years Yeah, I know. I'm the person who filed those PRs. I'm also the only person for the last 20 years who has consistently=20 tried to fix FreeBSD libm to be C99 compliant with quality implementations. > and you are about to attacking the first person, who tries to > address that issues. I am quite sure that is not the spirit > what the FreeBSD project is about. You're not the first person, and you're not the first person who tries to grab code from one of the other BSDs as a solution without understanding some of the nuances of the floating point environment of FreeBSD. Did you actually test the functions? Here's a test for your ccoshl, and its wrong results ccoshl(-0,-inf) =3D (nan,nan) expecting (nan,+0) ccoshl(-0,+inf) =3D (nan,nan) expecting (nan,-0) ccoshl(+0,+nan) =3D (nan,nan) expecting (nan,+0) ccoshl(+0,-nan) =3D (nan,nan) expecting (nan,-0) ccoshl(-0,-nan) =3D (nan,nan) expecting (nan,+0) ccoshl(-0,+nan) =3D (nan,nan) expecting (nan,-0) ccoshl(+inf,+0) =3D (nan,nan) expecting (+inf,+0) ccoshl(+inf,-0) =3D (nan,nan) expecting (+inf,-0) ccoshl(-inf,-0) =3D (nan,nan) expecting (+inf,+0) ccoshl(-inf,+0) =3D (nan,nan) expecting (+inf,-0) ccoshl(+nan,+0) =3D (nan,nan) expecting (nan,+0) ccoshl(+nan,-0) =3D (nan,nan) expecting (nan,-0) ccoshl(-nan,-0) =3D (nan,nan) expecting (nan,+0) ccoshl(-nan,+0) =3D (nan,nan) expecting (nan,-0) ccoshl(+inf,+nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,-nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,-nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,+nan) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,+inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,-inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,-inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(-inf,+inf) =3D (nan,nan) expecting (+inf,nan) ccoshl(+inf,1) =3D (nan,+inf) expecting (+inf*cos(y),+inf*sin(y)) ccoshl(-inf,1) =3D (nan,-inf) expecting (+inf*cos(y),-inf*sin(y)) --=20 You are receiving this mail because: You are the assignee for the bug.=