From owner-cvs-src@FreeBSD.ORG Wed May 23 20:58:48 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5D9BB16A46D; Wed, 23 May 2007 20:58:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 0514713C45D; Wed, 23 May 2007 20:58:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l4NKwf7l017990; Wed, 23 May 2007 16:58:41 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrew Gallatin Date: Wed, 23 May 2007 15:47:38 -0400 User-Agent: KMail/1.9.6 References: <200705231531.l4NFV12H058289@repoman.freebsd.org> <86bqgbs8kt.wl%rpaulo@fnop.net> <18004.36709.708317.994071@grasshopper.cs.duke.edu> In-Reply-To: <18004.36709.708317.994071@grasshopper.cs.duke.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705231547.38987.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 23 May 2007 16:58:41 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3287/Wed May 23 13:31:14 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Rui Paulo , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2007 20:58:48 -0000 On Wednesday 23 May 2007 03:00:30 pm Andrew Gallatin wrote: > > Rui Paulo writes: > > At Wed, 23 May 2007 15:31:01 +0000 (UTC), > > Andrew Gallatin wrote: > > > > > > gallatin 2007-05-23 15:31:01 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/pci pci_pci.c > > > Log: > > > Fix a typo in pcib_alloc_msi{x} which resulted in the > > > device's, not the bridge's, softc to be used to check the > > > PCIB_DISABLE_MSI flag. This resulted in randomly allowing > > > or denying MSI interrupts based on whatever value the driver > > > happened to store at sizeof(device_t) bytes into its softc. > > > > > > I noticed this when I stopped getting MSI interrupts > > > after slighly re-arranging mxge's softc yesterday. > > > > Wow, I'll have to try this out on msk(4).. > > To be clear, pci_alloc_msi() was failing, so MSI was not > used at all. It didn't affect the actual generation > of interrupts once MSI is enabled.. In some cases it gave you MSI when it shouldn't have, too. I do have at least one bug report on msk(4) that this might fix, as since it was checking the wrong softc, it could break on any system, not just ones with the broken bridges. -- John Baldwin