From owner-freebsd-mips@FreeBSD.ORG Fri Apr 1 19:05:23 2011 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E55721065674 for ; Fri, 1 Apr 2011 19:05:23 +0000 (UTC) (envelope-from bhanuprakashbodireddy@gmail.com) Received: from mail-px0-f172.google.com (mail-px0-f172.google.com [209.85.212.172]) by mx1.freebsd.org (Postfix) with ESMTP id B51D08FC15 for ; Fri, 1 Apr 2011 19:05:23 +0000 (UTC) Received: by pxi6 with SMTP id 6so2427258pxi.17 for ; Fri, 01 Apr 2011 12:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=xkpzpbPjoqM9af4EXxuJuc14k1siRbeAmmw00YMjG4E=; b=uoGOj17VFd9JfgVcmXDUz+J5lI+fOXTgT73q6jJa1Xz156i6WkHrYA7nv55CquDz32 aTvDjbX4Fmnv8Gc1AI42+f/wkp0dM95VzduIbfHplkoSkNcIHttBOIi5puXgHiRvrOZA OCeGD5FC8J8KmHOnLadVjkW4BCnoVunCnQa6c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=ds2dfLqgFaIjd7BrnJwFvhTxLLztwIs8het4ZKAH7zUhp/cKcHvZ7o0xJCvLOtz45g aKNKP6FskxTvjwX07sDgCUsmOR0B/DfwUH5SvH2Qmt60v3bXf00ttioeHzoSsUFy3vrU hAjsG7hKVh24p0bm48cc9RXXfdWH16AFEdhHs= MIME-Version: 1.0 Received: by 10.142.76.16 with SMTP id y16mr3282184wfa.157.1301684722192; Fri, 01 Apr 2011 12:05:22 -0700 (PDT) Received: by 10.142.222.3 with HTTP; Fri, 1 Apr 2011 12:05:22 -0700 (PDT) In-Reply-To: <4D961CB0.6080802@mahan.org> References: <4D961CB0.6080802@mahan.org> Date: Fri, 1 Apr 2011 12:05:22 -0700 Message-ID: From: bhanuprakash bodireddy To: Patrick Mahan Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-mips@freebsd.org Subject: Re: Blatant simple bug in Cavium SDK USB code? X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2011 19:05:24 -0000 On Fri, Apr 1, 2011 at 11:42 AM, Patrick Mahan wrote: > > > On 4/1/11 11:08 AM, Andrew Duane wrote: > > > > In the routine cvmx_usb_initialize in sys/contrib/octeon-sdk/cvmx-usb.c, > I'm pretty sure there's a silly little bug that really BADLY breaks the USB > driver for some of us. > > > > Near the top, after it finds board type and sets the clock type, as part > of the structure initialization, there is: > > > > memset(usb, 0, sizeof(usb)); > > > > Tell me that is not supposed to be: > > > > memset(usb, 0, sizeof(*usb)); > > > > The existing code only zeros 4/8 bytes, instead of the 23KB of the > structure. > > > > Ugh... Looks like this is an original bug from Cavium. No wonder I always > had issues working with the USB in u-boot off of the SDK. > > I see this is my 1.9 Cavium SDK. Not sure if it is on a more recent > version. > We already have 2.0 Simple Exec support merged on to Mainline. Unfortunately this bug wasn't detected. Thanks, Bhanu prakash. > > Patrick > _______________________________________________ > freebsd-mips@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org" >