From owner-freebsd-current@freebsd.org Sat Jan 23 10:51:57 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0F4944F05A5 for ; Sat, 23 Jan 2021 10:51:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DNCcW6NzVz3qb5 for ; Sat, 23 Jan 2021 10:51:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 10NApjLg015978 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 23 Jan 2021 12:51:48 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 10NApjLg015978 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 10NApi3R015977; Sat, 23 Jan 2021 12:51:44 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 23 Jan 2021 12:51:44 +0200 From: Konstantin Belousov To: Steve Kargl Cc: freebsd-current@freebsd.org Subject: Re: elfctl is broken Message-ID: References: <20210123011316.GA69125@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210123011316.GA69125@troutmask.apl.washington.edu> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4DNCcW6NzVz3qb5 X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2001:470:d5e7:1::1:from]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_SPF_SOFTFAIL(0.00)[~all:c]; SPAMHAUS_ZRD(0.00)[2001:470:d5e7:1::1:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.996]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MAILMAN_DEST(0.00)[freebsd-current]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2021 10:51:57 -0000 On Fri, Jan 22, 2021 at 05:13:16PM -0800, Steve Kargl wrote: > =3D=3D=3D> usr.bin/elfctl (all) > cc -target i386-unknown-freebsd14.0 --sysroot=3D/usr/obj/usr/src/i386.i38= 6/tmp -B/usr/obj/usr/src/i386.i386/tmp/usr/bin -O2 -pipe -fno-common -I/us= r/src/contrib/elftoolchain/li belftc -I/usr/src/contrib/elftoolchain/common= -march=3Dcore2 -MD -MF.depend.elfctl.o -MTelfctl.o -std=3Dgnu99 -Wno-for= mat-zero-length -fstack-protector-strong -Wsystem-headers - Werror -Wall -W= no-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-protot= ypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Ws= hadow -Wun used-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-= externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissin= g-variable-declarations -Wthread-saf ety -Wno-empty-body -Wno-string-plus-i= nt -Wno-unused-const-variable -Qunused-arguments -c /usr/src/usr.bin/el= fctl/elfctl.c -o elfctl.o /usr/src/usr.= bin/elfctl/elfctl.c:258:18: error: comparison of integers of different sign= s: 'long' and 'unsigned int' [- > Werror,-Wsign-compare] else if (val > U= INT_MAX) > ~~~ ^ ~~~~~~~~ = = =20 > 1 error generated. = = =20 > *** Error code 1 =20 >=20 https://reviews.freebsd.org/D28301