From owner-cvs-src@FreeBSD.ORG  Thu May  6 10:54:08 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3EB5616A4CF
	for <cvs-src@FreeBSD.org>; Thu,  6 May 2004 10:54:08 -0700 (PDT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 6137943D45
	for <cvs-src@FreeBSD.org>; Thu,  6 May 2004 10:54:07 -0700 (PDT)
	(envelope-from nate@root.org)
Received: (qmail 42548 invoked by uid 1000); 6 May 2004 17:54:08 -0000
Date: Thu, 6 May 2004 10:54:08 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <200405061241.42766.jhb@FreeBSD.org>
Message-ID: <20040506105124.O42462@root.org>
References: <200405061554.i46Fs3q4023478@repoman.freebsd.org>
 <200405061241.42766.jhb@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 legacy.c src/sys/kern subr_smp.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 May 2004 17:54:08 -0000

On Thu, 6 May 2004, John Baldwin wrote:
> On Thursday 06 May 2004 11:54 am, Nate Lawson wrote:
> > njl         2004/05/06 08:54:03 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/i386/i386        legacy.c
> >     sys/kern             subr_smp.c
> >   Log:
> >   Move the CPU newbus attachment to i386 legacy.  The acpi_cpu device will
> >   become just "cpu" and provide attachments in the !legacy case.
> >
> >   Tested by:      des
>
> By the way, it would be nice if the acpi_cpu(4) driver would still probe and
> attach to devices for non-existent CPUs but just device_disable() the
> associated device_t.  This would keep the device from reprobing all the time.

Good idea, I'll make that change tonight.  The code I committed this
morning returns ENXIO for them so probe will get called multiple times.
Hmm, this may be more difficult than I first thought since some of the
internal routines walk all devices in the devclass, operating on their
resources.  This change would require that code to have an extra case,
"device here but not active".  Right now it assumes that if the device is
probed/attached, it is usable.

-Nate