From owner-freebsd-bugs@FreeBSD.ORG Fri Mar 26 21:45:42 2004 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D634716A4CE for ; Fri, 26 Mar 2004 21:45:42 -0800 (PST) Received: from terpsi.otenet.gr (terpsi.otenet.gr [195.170.0.9]) by mx1.FreeBSD.org (Postfix) with ESMTP id ACD2043D58 for ; Fri, 26 Mar 2004 21:45:41 -0800 (PST) (envelope-from keramida@ceid.upatras.gr) Received: from gothmog.gr (patr530-b156.otenet.gr [212.205.244.164]) by terpsi.otenet.gr (8.12.10/8.12.10) with ESMTP id i2R5jaqs010381; Sat, 27 Mar 2004 07:45:37 +0200 (EET) Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.12.11/8.12.11) with ESMTP id i2R5jakg068921; Sat, 27 Mar 2004 07:45:36 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from giorgos@localhost) by gothmog.gr (8.12.11/8.12.11/Submit) id i2R5jaXY068920; Sat, 27 Mar 2004 07:45:36 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Sat, 27 Mar 2004 07:45:36 +0200 From: Giorgos Keramidas To: Kris Kennaway Message-ID: <20040327054536.GA68587@gothmog.gr> References: <200403261523.i2QFNhGS044804@gothmog.gr> <20040327040256.GA95621@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040327040256.GA95621@xor.obsecurity.org> cc: freebsd-bugs@freebsd.org Subject: Re: fetchmail-6.2.5 bug in FreeBSD-current X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2004 05:45:42 -0000 On 2004-03-26 20:02, Kris Kennaway wrote: > On Fri, Mar 26, 2004 at 05:23:43PM +0200, Giorgos Keramidas wrote: > > I'm in the middle of reinstalling all my ports/packages, after an > > upgrade to today's current and I just happened to notice a minor bug > > that breaks the POP3 protocol in version 6.2.5 of fetchmail. [...] > > --- pop3.c.orig Fri Mar 26 17:08:39 2004 > > +++ pop3.c Fri Mar 26 17:08:12 2004 > > @@ -916,7 +916,7 @@ > > unsigned int num, size; > > > > /* for POP3, we can get the size of one mail only! */ > > - if (first != last) > > + if (first == last) [...] > I've tried to report this to the fetchmail authors since last year, > and (when their mailing list was not misconfigured and rejecting > emails) have been unable to get a response. > > I'm not sure your patch is correct though - the check itself seems to > be correct ("Are we trying to fetch a range of messages?"), it's the > need for the check itself that seems broken. Looking more carefully at the check, I found out that you're absolutely right. The check's logic is fine as it is, it's the way that the pop3_getpartialsizes() function is called that is broken. Thanks for verifying that I'm not doing anything wrong that breaks fetchmail in other ways :-) - Giorgos