Date: Sat, 27 Mar 2004 07:45:36 +0200 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Kris Kennaway <kris@obsecurity.org> Cc: freebsd-bugs@freebsd.org Subject: Re: fetchmail-6.2.5 bug in FreeBSD-current Message-ID: <20040327054536.GA68587@gothmog.gr> In-Reply-To: <20040327040256.GA95621@xor.obsecurity.org> References: <200403261523.i2QFNhGS044804@gothmog.gr> <20040327040256.GA95621@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2004-03-26 20:02, Kris Kennaway <kris@obsecurity.org> wrote:
> On Fri, Mar 26, 2004 at 05:23:43PM +0200, Giorgos Keramidas wrote:
> > I'm in the middle of reinstalling all my ports/packages, after an
> > upgrade to today's current and I just happened to notice a minor bug
> > that breaks the POP3 protocol in version 6.2.5 of fetchmail.
[...]
> > --- pop3.c.orig Fri Mar 26 17:08:39 2004
> > +++ pop3.c Fri Mar 26 17:08:12 2004
> > @@ -916,7 +916,7 @@
> > unsigned int num, size;
> >
> > /* for POP3, we can get the size of one mail only! */
> > - if (first != last)
> > + if (first == last)
[...]
> I've tried to report this to the fetchmail authors since last year,
> and (when their mailing list was not misconfigured and rejecting
> emails) have been unable to get a response.
>
> I'm not sure your patch is correct though - the check itself seems to
> be correct ("Are we trying to fetch a range of messages?"), it's the
> need for the check itself that seems broken.
Looking more carefully at the check, I found out that you're absolutely
right. The check's logic is fine as it is, it's the way that the
pop3_getpartialsizes() function is called that is broken.
Thanks for verifying that I'm not doing anything wrong that breaks
fetchmail in other ways :-)
- Giorgos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040327054536.GA68587>