From owner-svn-src-projects@FreeBSD.ORG Thu Jul 9 08:32:53 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C4B6106566C; Thu, 9 Jul 2009 08:32:53 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-ew0-f224.google.com (mail-ew0-f224.google.com [209.85.219.224]) by mx1.freebsd.org (Postfix) with ESMTP id EDA028FC22; Thu, 9 Jul 2009 08:32:52 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ewy24 with SMTP id 24so449555ewy.43 for ; Thu, 09 Jul 2009 01:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=93x3wSJE2oj4GCyhSgGPFodDbEk7x0tzInvPMR82jyw=; b=wkAclGA4dga8GpSiRuomFVYEatMhxXk7v1901DdGk3SRqfdSSAnr1/AqDgWXhSkSNo Nibz5fi/Ho2HlCRc0XE6rcgNgQtaz14GhtwzFQnV33Jr8WqTKRAfNHH9+2wT0V2pg7e8 9O2QQGshil/w2UoLvbFCs9T3GuqfnK7BQjmgk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=VDwdzXrSjPqkB701H4ma5SblzrWK5txP77KW48EXkI84yjfHSWszgm2uY1k+/l36MZ znAT/Id+7ViYwTv782AszlP3pmaINDrQotLIqrKTxRF6U/GHuK+//B0aKjCDauiyc7oh xQaHG8gmeaz7sdJGe0gZVJpw05gjvsYAt/v+Y= Received: by 10.211.178.12 with SMTP id f12mr587924ebp.83.1247128372158; Thu, 09 Jul 2009 01:32:52 -0700 (PDT) Received: from omega.lan (bl6-157-190.dsl.telepac.pt [82.155.157.190]) by mx.google.com with ESMTPS id 23sm4650416eya.26.2009.07.09.01.32.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 09 Jul 2009 01:32:51 -0700 (PDT) Sender: Rui Paulo Message-Id: From: Rui Paulo To: Bruce Evans In-Reply-To: <20090709041145.G46111@delplex.bde.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 9 Jul 2009 09:32:51 +0100 References: <200907081526.n68FQYDb055185@svn.freebsd.org> <20090709041145.G46111@delplex.bde.org> X-Mailer: Apple Mail (2.935.3) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195460 - projects/mesh11s/sys/net80211 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2009 08:32:53 -0000 On 8 Jul 2009, at 19:24, Bruce Evans wrote: > On Wed, 8 Jul 2009, Rui Paulo wrote: > >> Log: >> Remove some spurious __packed attributes. > > Are they spurious? All uses of __packed are wrong, but they might > still > help work around ABI bugs. > >> Modified: >> projects/mesh11s/sys/net80211/ieee80211_mesh.h >> >> Modified: projects/mesh11s/sys/net80211/ieee80211_mesh.h >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- projects/mesh11s/sys/net80211/ieee80211_mesh.h Wed Jul 8 >> 15:25:27 2009 (r195459) >> +++ projects/mesh11s/sys/net80211/ieee80211_mesh.h Wed Jul 8 >> 15:26:34 2009 (r195460) >> @@ -46,7 +46,7 @@ struct ieee80211_meshconf_ie { >> uint8_t conf_authid[4]; /* Auth. Protocol ID */ >> uint8_t conf_form; /* Formation Information */ >> uint8_t conf_cap; >> -} __packed; >> +}; > > Broken ABIs (e.g., arm?) may add padding at the end of structs, so it > doesn't help for all members of a struct to have type uint8_t. I > think > arm always pads to make the size a multiple of 4. The natural size of > the above struct is 6, so it seems to need __packed. You're right. -- Rui Paulo