From owner-svn-src-all@FreeBSD.ORG  Mon Jan  6 19:49:06 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 82D1BCB7;
 Mon,  6 Jan 2014 19:49:06 +0000 (UTC)
Received: from mail-qc0-x22f.google.com (mail-qc0-x22f.google.com
 [IPv6:2607:f8b0:400d:c01::22f])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1C2731475;
 Mon,  6 Jan 2014 19:49:06 +0000 (UTC)
Received: by mail-qc0-f175.google.com with SMTP id e9so17806242qcy.20
 for <multiple recipients>; Mon, 06 Jan 2014 11:49:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=y5O72kt03YwyXsukDPaDWt0SOYu9j2sCsMW4EI941ow=;
 b=kxH5onnPyn7DVE7v55UgZ2uAqyWilNw+HW9KQygRfR/Q5sSzeYDmcKIEK53gt7I1TM
 oZlmQLtFyHI75lXRDwdWbPuIOvNMyCg0iXjQlHs8hpE6OH4SKlV0bPJdq4NhKh9gaAcu
 eteuzm89J8a37hN5JD7mOTMsDaBYRFAz7i/NYACu27KF9zt5wVzB2CFOmxBujqUWzNvw
 JHJYDN03FEZlj1ljNWkqXf2U2af51UvQrNWNKk80awOOHe1Epyl16w9EtIsMsz7f/x+g
 fuRU0FERlN0P9kRlylQyb7MHDYFvUiofMNd4EQ8wU+d2yyKJ259jjZRShelxXQhQSJLk
 m9eQ==
MIME-Version: 1.0
X-Received: by 10.224.46.8 with SMTP id h8mr181857506qaf.49.1389037745249;
 Mon, 06 Jan 2014 11:49:05 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.224.52.8 with HTTP; Mon, 6 Jan 2014 11:49:05 -0800 (PST)
In-Reply-To: <20140106173738.GG59496@kib.kiev.ua>
References: <201401060348.s063mW8C031852@svn.freebsd.org>
 <20140106035139.GC59496@kib.kiev.ua>
 <CAJ-VmomRefeAdd_VdRO8Q8jTpC2hbC7Q22vy_uJB7FX=OUUFLQ@mail.gmail.com>
 <20140106173738.GG59496@kib.kiev.ua>
Date: Mon, 6 Jan 2014 11:49:05 -0800
X-Google-Sender-Auth: SGTYwxdnXMN0IZil0uhyXkJTojY
Message-ID: <CAJ-VmonDF1eAu7=gUNY50aQR0qqZvpCXSLho8GGQqVaTQwaRwQ@mail.gmail.com>
Subject: Re: svn commit: r260363 - head/sys/dev/ath
From: Adrian Chadd <adrian@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2014 19:49:06 -0000

On 6 January 2014 09:37, Konstantin Belousov <kostikbel@gmail.com> wrote:
>> > This is a NOP, right ?
>>
>> Nope. the previous version didn't remove the entries from the list.
>> that's the bug.
> Hm, you mean that the previous version did not TAILQ_INIT() after the loop ?
> Then I agree.

Well, it's that the frames just get moved between the RX queue active
list(s) or the rxbuf inactive list. The correct thing to do is to
TAILQ_REMOVE them from one list before adding them to the free list.

-a