From owner-svn-src-head@freebsd.org Tue Dec 4 17:57:04 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D76C1314A6D; Tue, 4 Dec 2018 17:57:04 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3AC42860D8; Tue, 4 Dec 2018 17:57:03 +0000 (UTC) (envelope-from delphij@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id m19so14370832ioh.3; Tue, 04 Dec 2018 09:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0SIeMwCYXgcyULOCGfSCEAa56aMMJ8rVo0UCZ2O/8g8=; b=T3YAIbD48yKdA/O2lGrwT+6S4iebI+9I9jvlobkGJpk7Fj8xEbmZqqcjotaL7hVnXM DXVnfl7NT8YpUIAgKWWVyZvP5pFGuBBpLcGklmKsbYulKR2WXUZZcthHpRf0de70+36X 7rPu/hpclJL003IuEHVZIdPkx+FyxzbwBGOh0x5GGX0QIN5JVmlOXX4KTi9TlK+EZ7eK 19yyC+kaol4oKAB37QhcC8Qm5Jw3l13+KCPhjN72SELuJaPQ5dXV4P92ab6BeufioHi9 U7e/mV3AW/tRkIZ2GeWXcKb8T5mmlWBvEu5/LR+WWW7d6+K09294vcdWjlIXdYvL+dus l3wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0SIeMwCYXgcyULOCGfSCEAa56aMMJ8rVo0UCZ2O/8g8=; b=s3GRk5fj9ZDUqJGFNszB2zg0Aw0vEhK5PAjOq6OAGE9PlAQQFKYlb1tRIBCmx/0KHS keEhB5JDmCLkh/Z8etGxI/1IxuWw/fBg32FqMcyY3Lj2QgSLMY08JoubOA2r79VStW2/ 9oSipHSjUleCLn7bOSPD2doHo27PksOdkGFrKza9EhoVRtAWBG6cKpjEmIas2O9q74uF rgbWrr4HLcRoZmImFtjETp531C9oLA9mPs99Wv7s7kR5mUUREdxCwHtX9mgYGmXP6nWQ +nPZ23IXkBI/N0kp6Stov2LQkRzriWiFo0pWbZDlMrPEFO7Y24Ax3a6G+bT7ZczhlLKP Xncw== X-Gm-Message-State: AA+aEWareXHJxbFqcr35b2tMxo/TxPU8aTn/VXT7q4LBibMTGwogK20z hgb/vOJMiVFS6usNaEkVpyQ3VFTaAu/POWutFX7+sw== X-Google-Smtp-Source: AFSGD/XrBpHsDw94G/3zEz493cn7e/vxkWuNl90iMj5aQAyPVBTppVosxC5AxXJP91b592qqrrx6BFK5WikGnuWK1xQ= X-Received: by 2002:a6b:8e43:: with SMTP id q64mr17500267iod.197.1543946222018; Tue, 04 Dec 2018 09:57:02 -0800 (PST) MIME-Version: 1.0 References: <201812041234.wB4CYMTJ096164@repo.freebsd.org> <201812041728.wB4HSPes037239@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201812041728.wB4HSPes037239@pdx.rh.CN85.dnsmgr.net> From: Xin LI Date: Tue, 4 Dec 2018 09:56:50 -0800 Message-ID: Subject: Re: svn commit: r341464 - head/sbin/savecore To: rgrimes@freebsd.org Cc: Renato Botelho do Couto , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3AC42860D8 X-Spamd-Result: default: False [-6.06 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-2.05)[ip: (-7.36), ipnet: 2607:f8b0::/32(-1.54), asn: 15169(-1.28), country: US(-0.09)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[f.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.992,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 17:57:04 -0000 On Tue, Dec 4, 2018 at 9:28 AM Rodney W. Grimes wrote: > > > Author: garga (ports committer) > > Date: Tue Dec 4 12:34:22 2018 > > New Revision: 341464 > > URL: https://svnweb.freebsd.org/changeset/base/341464 > > > > Log: > > Restore /var/crash permissions to 0750, as declared in mtree file. After > > r337337 it changed to 0755. > > > > Reviewed by: loos > > Approved by: loos > > MFC after: 3 days > > Sponsored by: Rubicon Communications, LLC (Netgate) > > Differential Revision: https://reviews.freebsd.org/D18355 > > This probably warrants an EN against 12.0 release. Can we just fix it before 12.0-RELEASE builds starts? It would be much more robust compared to delivering a "fixit" script though freebsd-update... Cheers, > > > Modified: > > head/sbin/savecore/Makefile > > > > Modified: head/sbin/savecore/Makefile > > ============================================================================== > > --- head/sbin/savecore/Makefile Tue Dec 4 10:30:31 2018 (r341463) > > +++ head/sbin/savecore/Makefile Tue Dec 4 12:34:22 2018 (r341464) > > @@ -2,7 +2,9 @@ > > > > PACKAGE=runtime > > CONFS= minfree > > -CONFSDIR= /var/crash > > +VAR_CRASH= /var/crash > > +VAR_CRASH_MODE= 0750 > > +CONFSDIR= VAR_CRASH > > PROG= savecore > > LIBADD= z xo > > MAN= savecore.8 > > > > > > -- > Rod Grimes rgrimes@freebsd.org >