From owner-svn-src-user@FreeBSD.ORG Mon Oct 24 14:45:32 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 334541065670; Mon, 24 Oct 2011 14:45:32 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 239CC8FC12; Mon, 24 Oct 2011 14:45:32 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p9OEjWTW048470; Mon, 24 Oct 2011 14:45:32 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p9OEjWfe048468; Mon, 24 Oct 2011 14:45:32 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201110241445.p9OEjWfe048468@svn.freebsd.org> From: Adrian Chadd Date: Mon, 24 Oct 2011 14:45:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r226692 - user/adrian/if_ath_tx/sys/dev/ath X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2011 14:45:32 -0000 Author: adrian Date: Mon Oct 24 14:45:31 2011 New Revision: 226692 URL: http://svn.freebsd.org/changeset/base/226692 Log: Another thing fixed. Modified: user/adrian/if_ath_tx/sys/dev/ath/README Modified: user/adrian/if_ath_tx/sys/dev/ath/README ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/README Mon Oct 24 14:37:26 2011 (r226691) +++ user/adrian/if_ath_tx/sys/dev/ath/README Mon Oct 24 14:45:31 2011 (r226692) @@ -68,16 +68,6 @@ wlan0: [00:1b:b1:58:f6:f0] discard dupli Things that need doing! ----------------------- -* The txactive bits are set in the interrupt handler context, and cleared - in the TX completion process context. Since TX interrupts may occur - during a TX completion process, it's unfortunately likely that this - will be very racey and end up missing perfectly valid TX events. - This should be resolved before things are merged into -HEAD. - - Maybe store the txqactive mask away in ath_softc and put the update - of said ath_softc version behind an atomic operation or lock. That way - the HAL doesn't have to change (for now). - * When off-channel, aggregate traffic should stay queued, but raw frames (eg probes) should be sent? @@ -467,3 +457,16 @@ pid 1510 newma does this too (check ath_pkt_duration()) - done - it uses the whole aggregate length, incl. delimiters. +* The txactive bits are set in the interrupt handler context, and cleared + in the TX completion process context. Since TX interrupts may occur + during a TX completion process, it's unfortunately likely that this + will be very racey and end up missing perfectly valid TX events. + This should be resolved before things are merged into -HEAD. + + Maybe store the txqactive mask away in ath_softc and put the update + of said ath_softc version behind an atomic operation or lock. That way + the HAL doesn't have to change (for now). + + - done - this is currently protected by ATH_LOCK and shadowed in the + ath_softc. +