From owner-svn-ports-head@freebsd.org Sun Sep 29 19:41:49 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 55DCF128950; Sun, 29 Sep 2019 19:41:49 +0000 (UTC) (envelope-from pi@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46hGBP1ZsTz3NqZ; Sun, 29 Sep 2019 19:41:49 +0000 (UTC) (envelope-from pi@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 193881EECB; Sun, 29 Sep 2019 19:41:49 +0000 (UTC) (envelope-from pi@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x8TJfm6h088867; Sun, 29 Sep 2019 19:41:48 GMT (envelope-from pi@FreeBSD.org) Received: (from pi@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x8TJfmie088866; Sun, 29 Sep 2019 19:41:48 GMT (envelope-from pi@FreeBSD.org) Message-Id: <201909291941.x8TJfmie088866@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: pi set sender to pi@FreeBSD.org using -f From: Kurt Jaeger Date: Sun, 29 Sep 2019 19:41:48 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r513264 - head/net-mgmt/net-snmp/files X-SVN-Group: ports-head X-SVN-Commit-Author: pi X-SVN-Commit-Paths: head/net-mgmt/net-snmp/files X-SVN-Commit-Revision: 513264 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Sep 2019 19:41:49 -0000 Author: pi Date: Sun Sep 29 19:41:48 2019 New Revision: 513264 URL: https://svnweb.freebsd.org/changeset/ports/513264 Log: net-mgmt/net-snmp: fix for first byte of IF-MIB::ifPhysAddress is always 0 - netsnmp_arch_interface_container_load() writes terminating NUL directly to the sdl_data *past* the length specified in sdl_nlen, overwriting first byte of physadrr. PR: 231996 Submitted by: Yuri Pankov Reviewed by: Bart Van Assche (upstream maintainer) Approved by: zi (maintainer) Obtained from: https://sourceforge.net/p/net-snmp/code/merge-requests/20/ Added: head/net-mgmt/net-snmp/files/patch-agent_mibgroup_if-mib_data__access_interface__sysctl.c (contents, props changed) Added: head/net-mgmt/net-snmp/files/patch-agent_mibgroup_if-mib_data__access_interface__sysctl.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/net-mgmt/net-snmp/files/patch-agent_mibgroup_if-mib_data__access_interface__sysctl.c Sun Sep 29 19:41:48 2019 (r513264) @@ -0,0 +1,24 @@ +--- agent/mibgroup/if-mib/data_access/interface_sysctl.c.orig 2018-07-16 16:33:40 UTC ++++ agent/mibgroup/if-mib/data_access/interface_sysctl.c +@@ -531,8 +531,11 @@ + } + } + adl = (struct sockaddr_dl *) a; +- if_name = (char *) adl->sdl_data; +- if_name[adl->sdl_nlen] = '\0'; ++ if_name = malloc(adl->sdl_nlen + 1); ++ if (if_name) { ++ memcpy(if_name, adl->sdl_data, adl->sdl_nlen); ++ if_name[adl->sdl_nlen] = '\0'; ++ } + } + if (!(ifp->ifm_addrs & RTA_IFP) || if_name == NULL) { + snmp_log(LOG_ERR, "ifm_index %u: no interface name in message, " +@@ -541,6 +544,7 @@ + } + + entry = netsnmp_access_interface_entry_create(if_name, ifp->ifm_index); ++ free(if_name); + if(NULL == entry) { + netsnmp_access_interface_container_free(container, + NETSNMP_ACCESS_INTERFACE_FREE_NOFLAGS);