Date: Thu, 03 Jul 2008 19:37:19 +0400 From: Alexander Sabourenkov <screwdriver@lxnt.info> To: gary.jennejohn@freenet.de Cc: usb@freebsd.org, Luigi Rizzo <rizzo@icir.org>, current@freebsd.org Subject: Re: may I commit this small umodem patch ? Message-ID: <486CF22F.3080901@lxnt.info> In-Reply-To: <20080703170700.3b91b8c6@peedub.jennejohn.org> References: <20080703140719.GA72315@onelab2.iet.unipi.it> <20080703170700.3b91b8c6@peedub.jennejohn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gary Jennejohn wrote: > On Thu, 3 Jul 2008 16:07:19 +0200 > Luigi Rizzo <rizzo@icir.org> wrote: > [...] >>> +#if 1 >>> + if (ret == UMATCH_NONE && >>> + id->bInterfaceClass == UICLASS_CDC_DATA && >>> + id->bInterfaceSubClass == UISUBCLASS_DATA && >>> + id->bInterfaceProtocol == 0x00) >>> + ret = UMATCH_IFACECLASS_IFACESUBCLASS_IFACEPROTO; >>> + return ret; >>> +#endif >>> + >>> if (ret == UMATCH_NONE) >>> return (ret); > > Is there any reason to keep the #if 1 ... #endif? And why not just > directly return UMATCH_IFACECLASS_IFACESUBCLASS_IFACEPROTO rather than > assigning it to ret first? This patch also makes all statements below ''return ret;'' unreachable. I think it should be rewritten. -- ./lxnt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?486CF22F.3080901>