Date: Thu, 26 Apr 2012 17:09:49 -0600 From: Warner Losh <imp@bsdimp.com> To: Ian Lepore <freebsd@damnhippie.dyndns.org> Cc: freebsd-embedded@freebsd.org Subject: Re: make -jN xdev can fail Message-ID: <B9C57141-A353-41FF-B38D-B655607CFA44@bsdimp.com> In-Reply-To: <1335453287.66865.46.camel@revolution.hippie.lan> References: <1335453287.66865.46.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ian,
Good catch! I've never hit this, but most of the time I don't do -j =
builds.
Warner
On Apr 26, 2012, at 9:14 AM, Ian Lepore wrote:
> I discovered 'make xdev' can fail with -jN because it tries to run the
> xdev-install step while xdev-build is still running.
>=20
> The attached patch makes xdev-install depend on xdev-build to fix it.
>=20
> -- Ian
>=20
> Index: Makefile.inc1
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Makefile.inc1 (revision 234710)
> +++ Makefile.inc1 (working copy)
> @@ -1649,8 +1649,8 @@
> mtree -deU -f ${.CURDIR}/etc/mtree/BSD.include.dist \
> -p ${XDDESTDIR}/usr/include >/dev/null
>=20
> -.ORDER: _xi-mtree _xi-cross-tools _xi-includes _xi-libraries =
_xi-links
> -xdev-install: _xi-mtree _xi-cross-tools _xi-includes _xi-libraries =
_xi-links
> +.ORDER: xdev-build _xi-mtree _xi-cross-tools _xi-includes =
_xi-libraries _xi-links
> +xdev-install: xdev-build _xi-mtree _xi-cross-tools _xi-includes =
_xi-libraries _xi-links
>=20
> _xi-cross-tools:
> @echo "_xi-cross-tools"
> _______________________________________________
> freebsd-embedded@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-embedded
> To unsubscribe, send any mail to =
"freebsd-embedded-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B9C57141-A353-41FF-B38D-B655607CFA44>