From owner-svn-src-head@FreeBSD.ORG Thu Dec 29 09:34:11 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D97EA106566C; Thu, 29 Dec 2011 09:34:11 +0000 (UTC) (envelope-from ray@dlink.ua) Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id 8DC318FC12; Thu, 29 Dec 2011 09:34:11 +0000 (UTC) Received: from terran.dlink.ua (unknown [192.168.10.90]) (Authenticated sender: ray) by smtp.dlink.ua (Postfix) with ESMTPSA id DB5CAC493C; Thu, 29 Dec 2011 11:34:09 +0200 (EET) Date: Thu, 29 Dec 2011 11:34:26 +0200 From: Aleksandr Rybalko To: Oleksandr Tymoshenko Message-Id: <20111229113426.14c9acc3.ray@dlink.ua> In-Reply-To: <4EFBDC7F.9000605@freebsd.org> References: <201112280557.pBS5v3HZ085555@svn.freebsd.org> <20111228121541.9698722c.ray@dlink.ua> <4EFBDC7F.9000605@freebsd.org> Organization: D-Link X-Mailer: Sylpheed 2.7.1 (GTK+ 2.20.1; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228925 - head/sys/mips/cavium X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2011 09:34:12 -0000 On Wed, 28 Dec 2011 19:20:31 -0800 Oleksandr Tymoshenko wrote: >> On 28/12/2011 2:15 AM, Aleksandr Rybalko wrote: >> > On Wed, 28 Dec 2011 05:57:03 +0000 (UTC) >> > Oleksandr Tymoshenko wrote: >> > >> >>> Author: gonzo >> >>> Date: Wed Dec 28 05:57:03 2011 >> >>> New Revision: 228925 >> >>> URL: http://svn.freebsd.org/changeset/base/228925 >> >>> >> >>> Log: >> >>> - Add generic GPIO driver for Cavium Octeon. At the moment pin >> >>> definition is hardcoded but will be changed later with more >> >>> flexible way to define them. >> /* __OCTEON_GPIOVAR_H__ */ >> > >> > Thank you very much Oleksandr! >> > >> > Oleksandr, can you please avoid define board depended futures in >> > a SoC drivers in future '{ "F/D", 7, GPIO_PIN_INPUT}'? So others >> > will be able to use driver in different boards w/o modification >> > (just by define it in hints/FDT or so). >> >> OK, I'll remove it soon. It supposed to be just example. >> Thanks again! it just confuse peoples a bit, even developers. i remember adri say "many words" about it when he remove board depended struct from atheros gpio driver :) Anyway thanks! I will try to use/modify it ASAP and will send patches for review to you and my mentor of course. -- Alexandr Rybalko aka Alex RAY