From owner-svn-src-all@FreeBSD.ORG Tue Nov 18 23:18:25 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C7551065670; Tue, 18 Nov 2008 23:18:25 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121]) by mx1.freebsd.org (Postfix) with ESMTP id 1856B8FC22; Tue, 18 Nov 2008 23:18:23 +0000 (UTC) (envelope-from mav@FreeBSD.org) X-Spam-Flag: SKIP X-Spam-Yversion: Spamooborona-2.1.0 Received: from [212.86.226.226] (account mav@alkar.net HELO mavbook.mavhome.dp.ua) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9) with ESMTPSA id 227882534; Wed, 19 Nov 2008 01:18:23 +0200 Message-ID: <49234D3C.5030605@FreeBSD.org> Date: Wed, 19 Nov 2008 01:18:20 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.17 (X11/20081029) MIME-Version: 1.0 To: Maxim Konovalov References: <200811181548.mAIFmNuL081972@svn.freebsd.org> <20081118234224.M56769@mp2.macomnet.net> In-Reply-To: <20081118234224.M56769@mp2.macomnet.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r185053 - head/usr.sbin/powerd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2008 23:18:25 -0000 Maxim Konovalov wrote: >> Author: mav >> Date: Tue Nov 18 15:48:23 2008 >> New Revision: 185053 >> URL: http://svn.freebsd.org/changeset/base/185053 >> >> Log: >> Restore original frequency on exit. >> >> PR: bin/113813 >> > [ patch skipped ] > > Not sure this is a correct aproach. What happen if admin > changed (rose or lowered) the debug.cpufreq.lowest after he > run powerd? So imho at exit we need to take an account a > current value of debug.cpufreq.lowest. Then powerd may not restore original frequency. IMHO it is a bad idea to modify anything frequency related while powerd is running as it reads frequency set only once and them mostly writes. Every tool should have it's own task. powerd has no idea about debug.cpufreq.lowest, especially because of "debug.". It is kernel internal business, how to generate set of frequencies. If we need specify lowest frequency for adaptive mode, I would teach powerd to do it, not the kernel. -- Alexander Motin