From owner-freebsd-hackers  Fri Jun 23 04:18:33 1995
Return-Path: hackers-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id EAA03382
          for hackers-outgoing; Fri, 23 Jun 1995 04:18:33 -0700
Received: from physics.su.oz.au (dawes@physics.su.OZ.AU [129.78.129.1])
          by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id EAA03375
          for <hackers@freebsd.org>; Fri, 23 Jun 1995 04:18:28 -0700
Received: by physics.su.oz.au id AA16511
  (5.67b/IDA-1.4.4 for hackers@freebsd.org); Fri, 23 Jun 1995 21:18:15 +1000
From: David Dawes <dawes@physics.usyd.edu.au>
Message-Id: <199506231118.AA16511@physics.su.oz.au>
Subject: "in getcc reselect by t0" message from ncr.c
To: hackers@freebsd.org
Date: Fri, 23 Jun 1995 21:18:12 +1000 (EST)
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Content-Length: 2073      
Sender: hackers-owner@freebsd.org
Precedence: bulk

Today I noticed a few:

  in getcc reselect by t0.

messages in the dmesg output on my PCI with NCR scsi machine running
2.0.5R.  I had a look at pci/ncr.c, and it seems like this is part of
a debugging message that is incorrectly being printed out when debugging
is not enabled.  However, does this indicate any sort of problem?
I added a second SCSI disk last night, and I don't recall seeing this
message prior to then.  Everything appears to be working fine though
(I'm one of the silent majority who is highly appreciative of Stefan
and Wolfgang's work on the NCR SCSI driver).

If it helps any, this is what ncrcontrol reports:

T:L  Vendor   Device           Rev  Speed   Max Wide Tags
0:0  SEAGATE  ST31200N         9410  10.0  10.0   8    4
2:0  CONNER   CP30540 545MB3.5 B0BC  10.0  10.0   8    4
4:0  HP       HP35470A         9 09   5.0  10.0   8    -
5:0  PIONEER  CD-ROM DR-124X   1.00   4.4  10.0   8    -

BTW, I've just noticed that 'scsi -f /dev/rsd0.ctl -m 8' no longer
interprets/formats the output.  It used to work OK (a week or two
ago).  I've checked that /usr/share/misc/scsi_modes exists.  When
adding the extra disk, I modified the kernel to wire down the disks
(target 0 -> sd0, target 2 -> sd2).  I don't know if this is related or
not.  When I have a chance to reboot the old kernel I'll check that.

The following patch does what I think is intended regarding this
debugging message.

Index: src/sys/pci/ncr.c
*** 1.1.1.4	1995/06/13 12:59:32
--- ncr.c	1995/06/23 10:41:32
***************
*** 5453,5462 ****
  		**	a target reselected us.
  		**-------------------------------------------
  		*/
! 		if (DEBUG_FLAGS & DEBUG_RESTART)
  			PRINT_ADDR(cp->xfer);
  			printf ("in getcc reselect by t%d.\n",
  				INB(nc_ssid)&7);
  
  		/*
  		**	Mark this job
--- 5453,5463 ----
  		**	a target reselected us.
  		**-------------------------------------------
  		*/
! 		if (DEBUG_FLAGS & DEBUG_RESTART) {
  			PRINT_ADDR(cp->xfer);
  			printf ("in getcc reselect by t%d.\n",
  				INB(nc_ssid)&7);
+ 		}
  
  		/*
  		**	Mark this job


David