From owner-svn-src-head@freebsd.org Mon Mar 6 19:35:14 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15843CFB4E3; Mon, 6 Mar 2017 19:35:14 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D9BF91B00; Mon, 6 Mar 2017 19:35:13 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 0DBEB635C; Mon, 6 Mar 2017 19:35:13 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 2012D31FB8; Mon, 6 Mar 2017 19:35:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id Zkn8PG-MBcHW; Mon, 6 Mar 2017 19:34:59 +0000 (UTC) Subject: Re: svn commit: r314709 - head DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 23CCD31FB1 To: Ian Lepore , rgrimes@freebsd.org References: <201703061915.v26JFSSd089794@pdx.rh.CN85.dnsmgr.net> <1488828735.18764.43.camel@freebsd.org> Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Organization: FreeBSD Message-ID: Date: Mon, 6 Mar 2017 11:34:38 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1488828735.18764.43.camel@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8evJp0pvDxacEpo7DWNtIXqQgiflsvkAa" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 19:35:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8evJp0pvDxacEpo7DWNtIXqQgiflsvkAa Content-Type: multipart/mixed; boundary="lVonaw8jt7pq03hxJJu5XqP0tabbBEmoS"; protected-headers="v1" From: Bryan Drewery To: Ian Lepore , rgrimes@freebsd.org Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Subject: Re: svn commit: r314709 - head References: <201703061915.v26JFSSd089794@pdx.rh.CN85.dnsmgr.net> <1488828735.18764.43.camel@freebsd.org> In-Reply-To: <1488828735.18764.43.camel@freebsd.org> --lVonaw8jt7pq03hxJJu5XqP0tabbBEmoS Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/6/17 11:32 AM, Ian Lepore wrote: > On Mon, 2017-03-06 at 11:15 -0800, Rodney W. Grimes wrote: >> [ Charset ISO-8859-1 unsupported, converting... ] >>> >>> On Mon, 2017-03-06 at 10:32 -0800, Rodney W. Grimes wrote: >>>> >>>> [ Charset ISO-8859-1 unsupported, converting... ] >>>>> >>>>> >>>>> On Sun, 2017-03-05 at 19:12 -0800, Bryan Drewery wrote: >>>>>> >>>>>> >>>>>> On 3/5/17 3:41 PM, Warner Losh wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Sun, Mar 5, 2017 at 2:16 PM, Bryan Drewery >>>>>> ebsd >>>>>>> .org >>>>>>>> >>>>>>>> >>>>>>>> wrote: >>>>>>>> >>>>>>>> Author: bdrewery >>>>>>>> Date: Sun Mar??5 21:16:50 2017 >>>>>>>> New Revision: 314709 >>>>>>>> URL: https://svnweb.freebsd.org/changeset/base/314709 >>>>>>>> >>>>>>>> Log: >>>>>>>> ? Fix bootstrapping mtree after r313404 for older >>>>>>>> systems. >>>>>>>> >>>>>>>> ? r313404 made libnetbsd require sha384.h from >>>>>>>> libmd.??Libmd >>>>>>>> added it in >>>>>>>> ? r292782.??Update BOOTSTRAPPING to account for this. >>>>>>>> >>>>>>>> ? Reported by:??bde >>>>>>>> ? Reviewed by:??ngie >>>>>>>> >>>>>>>> Modified: >>>>>>>> ? head/Makefile.inc1 >>>>>>>> >>>>>>>> Modified: head/Makefile.inc1 >>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>> =3D=3D=3D=3D >>>>>>>> =3D=3D=3D=3D >>>>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>>>> --- head/Makefile.inc1??Sun Mar??5 19:56:20 >>>>>>>> 2017????????(r314708) >>>>>>>> +++ head/Makefile.inc1??Sun Mar??5 21:16:50 >>>>>>>> 2017????????(r314709) >>>>>>>> @@ -1618,10 +1618,12 @@ ${_bt}-usr.bin/m4: ${_bt}- >>>>>>>> lib/libopenbsd >>>>>>>> ?${_bt}-usr.bin/lex: ${_bt}-usr.bin/m4 >>>>>>>> ?.endif >>>>>>>> >>>>>>>> -.if ${BOOTSTRAPPING} < 1000026 >>>>>>>> -_nmtree=3D???????lib/libnetbsd \ >>>>>>> I've been trying to document the bootstrapping stuff inline >>>>>>> like >>>>>>> >>>>>>> # r313404 made libnetbsd require libmd >>>>>> Definitely.??I forgot about that.??I think my change is >>>>>> incomplete >>>>>> and >>>>>> need to chase down a 2nd failure report.??I'll add the >>>>>> comment >>>>>> once >>>>>> that >>>>>> is figured out. >>>>>> >>>>> I tracked this down to the fact that the prototype >>>>> >>>>> ? char * MD5FileChunk(const char *, char *, off_t, off_t); >>>>> >>>>> does not exist in /usr/include/sys/md5.h on older systems. ?I >>>>> don't >>>>> see >>>>> any straightforward way to declare that a header file from the >>>>> /usr/include hierarchy is a bootstrap item that needs a newer >>>>> version >>>>> from the source tree being compiled. ?It looks like such a >>>>> header >>>>> would >>>>> have to go into the obj/.../tmp/legacy/usr/include to get used >>>>> in >>>>> the >>>>> boostrap compile, I just don't see how you get a file installed >>>>> there >>>>> early enough in bootstrap. >>>> One way around this is to use the old concept of /usr/include >>>> symlinks >>>> into the src tree, not sure if you can still do that or not, but >>>> something like >>>> (cd /usr/src/include; make install SHARED=3Dsymlinks) >>>> >>>> A bootstrapping regresssion test I use to run was to rm -r >>>> /usr/include/* >>>> before a buildworld run, that would find these issues so they >>>> could >>>> be fixed before they become forgotten. >>>> ? >>> Making my live 10-stable system's /usr/include have symlinks into a >>> 11- >>> or 12- source tree is just not an option in any way. ?The first >>> question would be "which source tree" because I have like a dozen >>> of >>> them, not a single one of them rooted at /usr/src (which is an >>> empty >>> dir). >> I dont know that the support of CUrrent -2 building -current with >> a bootstraping include issue is ever going to be workable. You >> could try to build a proper include tree someplace to use, this >> can be done with >> (cd; usr/src/include; make install DESTDIR=3D/my/new/tree) This >> well not touch your /usr/include, but give you a proper include tree, >> now the work is to get buildworld to use that include tree. >> >> If buildworld has degnerated to using stuff out of /usr/include >> that also needs to be fixed ASAP. >> >>> >>> >>> This can't be the first time in 30+ years that system header files >>> had >>> to participate in the process of bootstrapping early build tools, >>> but I >>> don't see any machinery in Makefile.inc1 for dealing with it. >> Happens often, hence why I had that regression test. But >> bootstrapping >> on Current-2 has never been supported and probably never well be >> supported. >=20 > I'm aware that we officially only support building from current-1, but > we've worked hard to do much better than that for many years. >=20 > The only time I can think of it breaking in the last 10-12 years was > late in the 10-current cycle we reached a point where I could no longer= > build 10-current on an 8-stable system. That was a special case due to= > the cutover from gcc to clang and all the related changes. (Even with > that, I had it "almost working" but decided not to finish it and commit= > all the changes involved because they would have just gotten in the way= > of other modernization going on in the build system). >=20 > The reality is, a lot of people rely on building current from current-2= =20 > systems for a variety of reasons, and it's worth putting some effort > into supporting that. >=20 There is also a lot of demand for building from Linux or OSX. That will require additional bootstrapping. Either way, we'll never get away from bootstrapping, and the cost of keeping current-2 support is pretty low. --=20 Regards, Bryan Drewery --lVonaw8jt7pq03hxJJu5XqP0tabbBEmoS-- --8evJp0pvDxacEpo7DWNtIXqQgiflsvkAa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJYvbnOAAoJEDXXcbtuRpfPR1AH/iPmu7wPizyEVHzgWu9pDxFL F75mDgPva3zND7/3FBY1Qe7INHvijiLexD2FR5sPXqJzk6IgKDVMwpk4a80/w9gj kCWw8F4k80sOZRULvKBJfr6Y3ASv1JEFkSRaS/hQLBGWVfjhUG6fgJWzsP3lJPx9 Uv73LD++wmRfZfibx7tvgwvnlBZNUB2HAoCd8HQvKX8onGu9uTsmDTMg5/7U/mo8 mYDKdvbn/L3a5RPhbf9A5A3WeQmjZ1V1Ckd5fllsuhN4mo/Qy1pOkRtwQ78405LW riBNAPVAZqjHLwr9GnxS6daSgRzz7chkH32pLsahfZvMiIIQd/JdEdhF1WEBj2Q= =I86w -----END PGP SIGNATURE----- --8evJp0pvDxacEpo7DWNtIXqQgiflsvkAa--