From owner-freebsd-xen@freebsd.org Wed Feb 15 12:31:53 2017 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 38468CDF235 for ; Wed, 15 Feb 2017 12:31:53 +0000 (UTC) (envelope-from prvs=21221c659=roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [185.25.65.24]) (using TLSv1.2 with cipher RC4-SHA (128/128 bits)) (Client CN "mail.citrix.com", Issuer "DigiCert SHA2 Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89F071594 for ; Wed, 15 Feb 2017 12:31:51 +0000 (UTC) (envelope-from prvs=21221c659=roger.pau@citrix.com) X-IronPort-AV: E=Sophos;i="5.35,165,1484006400"; d="scan'208";a="40811483" Date: Wed, 15 Feb 2017 12:31:45 +0000 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: liuyingdong CC: , , , , , , Subject: Re: Multiple patch review =?utf-8?Q?=28was?= =?utf-8?B?OiBSZTog562U5aSNOiDnrZTlpI06IFtQQVRDSF1uZXRmcm9udDogbmVlZCBy?= =?utf-8?Q?eleas?= =?utf-8?Q?e?= all resources) after adding and removing NICs time and again Message-ID: <20170215123145.ucobkwzft6jrgcsu@dhcp-3-221.uk.xensource.com> References: <1676c942-84ec-e573-42e9-8debd47aeb1b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170206 (1.7.2) X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 12:31:53 -0000 On Wed, Feb 15, 2017 at 02:06:36PM +0200, liuyingdong wrote: > On 2017/2/13 12:05, liuyingdong wrote: > > 发件人: roger.pau@citrix.com [mailto:roger.pau@citrix.com] > > 发送时间: 2017年2月10日 17:12 > > 收件人: Liuyingdong > > 抄送: freebsd-xen@freebsd.org; Suoben ; Zhaojun (Euler) ; Wanglinkai ; chuzhaosong ; Wangchunfeng (Ivan) ; Gaoxiaodong (Leo) > > 主题: Multiple patch review (was: Re: 答复: 答复: [PATCH]netfront: need release all resources) after adding and removing NICs time and again > > > > On Tue, Feb 07, 2017 at 04:55:34PM +0000, Liuyingdong wrote: > >> Hi Roger, > >> I am so sorry and please review tne below URL: > >> https://lists.freebsd.org/pipermail/freebsd-xen/2017-February/002957.h > >> tml > > > > Hello, > > > > Thanks for the patches, and sorry for the delay. It seems like you have not applied some of my comments, so I will have to re-post them here. If some of the comments don't apply for whatever reason, please reply back and explain why, or else this is not going to progress in an useful way for any of us. > > > > I would also request you to look into using `git send-email`, reviewing your patches as attachments is not very comfortable. Or else, you could create an account to https://reviews.freebsd.org/ and upload the patches there assigning me as a reviewer. > > > I have created an account to https://reviews.freebsd.org/ and uploaded the patches but I cann't assign you as a reviewer so I assign visible to All Users. > The three modified patches are as follows: > 1.https://reviews.freebsd.org/differential/diff/25207/ > 2.https://reviews.freebsd.org/differential/diff/25208/ > 3.https://reviews.freebsd.org/differential/diff/25209/ You need to finish creating the revision, click on "Continue", and add a title/description and reviewers, see https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface for more information. Roger.