From owner-cvs-all Tue Feb 27 0:21:46 2001 Delivered-To: cvs-all@freebsd.org Received: from rina.r.dl.itc.u-tokyo.ac.jp (rina.r.dl.itc.u-tokyo.ac.jp [133.11.199.247]) by hub.freebsd.org (Postfix) with ESMTP id CAF1D37B718; Tue, 27 Feb 2001 00:21:32 -0800 (PST) (envelope-from tanimura@r.dl.itc.u-tokyo.ac.jp) Received: from rina.r.dl.itc.u-tokyo.ac.jp (localhost [127.0.0.1]) by rina.r.dl.itc.u-tokyo.ac.jp (8.11.1+3.4W/3.7W-rina.r-0.1-11.01.2000) with ESMTP id f1R8LUg04314; Tue, 27 Feb 2001 17:21:30 +0900 (JST) Date: Tue, 27 Feb 2001 17:21:30 +0900 Message-ID: From: Seigo Tanimura To: jhb@FreeBSD.org Cc: tanimura@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/sound/isa emu8000.c gusmidi.c mpu.c In-Reply-To: In your message of "Mon, 26 Feb 2001 10:50:52 -0800 (PST)" References: <200102260736.f1Q7aPd19490@freefall.freebsd.org> User-Agent: Wanderlust/1.1.1 (Purple Rain) SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) MULE XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd) Organization: Digital Library Research Division, Information Techinology Centre, The University of Tokyo MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 26 Feb 2001 10:50:52 -0800 (PST), John Baldwin said: >> - Mutexify midi(4). The driver runs under the giant lock by default. >> If you ever want to run midi(4) out of the giant lock, uncomment >> MIDI_OUTOFGIANT in midi.h. Confirmed to work for csamidi with WITNESS >> and INVARIANTS. John> Err, I hope that you do all mutex operations regardless, and only use this I will do that in my next commit. John> option to control setting the INTR_MPSAFE flag for any interrupt handlers that John> midi uses. Since some interrupt handlers are shared with pcm(4), we have to wait for pcm(4) to be MP-safe. A couple of questions to ask: A. As we might hold a mutex of VM and block, malloc(9) should be called with holding no mutexes except for Giant. Is that right? B. Is PI_AV for a multimedia device? If so, I would like to add INTR_TYPE_AV to enum intr_type and ithread_priority() so that pcm and midi devices can interrupt at PI_AV. -- Seigo Tanimura To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message