From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jun 16 16:40:56 2015 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 55AD9D6C for ; Tue, 16 Jun 2015 16:40:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3EB32EA6 for ; Tue, 16 Jun 2015 16:40:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5GGeuui009415 for ; Tue, 16 Jun 2015 16:40:56 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 200914] [PATCH] net/relayd rc.d script doesn't check configuration validity Date: Tue, 16 Jun 2015 16:40:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: dam@my.gd X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mm@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 16:40:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200914 Bug ID: 200914 Summary: [PATCH] net/relayd rc.d script doesn't check configuration validity Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: mm@FreeBSD.org Reporter: dam@my.gd Assignee: mm@FreeBSD.org Flags: maintainer-feedback?(mm@FreeBSD.org) Keywords: patch Created attachment 157808 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=157808&action=edit patch rc.d script to check configuration validity The init script for net/relayd does not check the configuration file for errors before trying to restart the daemon. As such, it is prone to errors when a tired admin breaks his config, invokes the script to restart relayd, and ends up with a service outage. This small patch inspired by nginx's rc.d adds support for configuration sanity checks before start, reload and restart actions. It simply issues a relayd -n to ensure the configuration file is sane. Validated working on 8-STABLE using relayd-5.5.20140810 -- You are receiving this mail because: You are the assignee for the bug.