From owner-freebsd-stable@FreeBSD.ORG Thu May 24 20:09:44 2007 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 303DE16A468 for ; Thu, 24 May 2007 20:09:44 +0000 (UTC) (envelope-from rmarella@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.232]) by mx1.freebsd.org (Postfix) with ESMTP id DCE5213C484 for ; Thu, 24 May 2007 20:09:43 +0000 (UTC) (envelope-from rmarella@gmail.com) Received: by nz-out-0506.google.com with SMTP id m22so587336nzf for ; Thu, 24 May 2007 13:09:43 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; b=XOkT2VP9E2tWXDxEHtfq2Jt4H7eRzs2kafYfUwrJbNNsmMosk92GZcN/CHPKuC+VKNSzNGmOHcfmXjurBosLcret1FlDIAJ1dfak3aYbf2CuDYNVRN8IwNKpVtORSnqdBwWqvlpbkYSmpirBo9V5B1mTP/8PBifo+mgBcKg2P8Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; b=qgJGJJI9OizOq3pOik07tmq/3KKNzOhwj5HHY3y+yEDnGPP8fTae3SajM65bBs+v+XbCGT9TLa3+IddeWHw2fbQZo9bSD8EFs9zaHqHsjqYb+lQKjMdscGZzTq0dCTQMQddzQzNR5agzk5IJ94wb5HJMutA8OUHcDH0JE4CqHLk= Received: by 10.114.146.1 with SMTP id t1mr1133941wad.1180037382485; Thu, 24 May 2007 13:09:42 -0700 (PDT) Received: from p4 ( [24.165.34.55]) by mx.google.com with ESMTP id y11sm1168151pod.2007.05.24.13.09.40; Thu, 24 May 2007 13:09:41 -0700 (PDT) Date: Thu, 24 May 2007 10:09:38 -1000 From: Robert Marella To: JoaoBR Message-ID: <20070524100938.04523259@p4> In-Reply-To: <200705241641.01894.joao@matik.com.br> References: <200705231244.21154.joao@matik.com.br> <200705241548.04988.joao@matik.com.br> <20070524091002.125487c0@p4> <200705241641.01894.joao@matik.com.br> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.12; i386-portbld-freebsd6.2) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_2xhkw9d8IeG+6yR0/0r5ylz" Cc: freebsd-stable@freebsd.org Subject: Re: atapicam cd error X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2007 20:09:44 -0000 --MP_2xhkw9d8IeG+6yR0/0r5ylz Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thu, 24 May 2007 16:41:01 -0300 JoaoBR wrote: > > > On Thursday 24 May 2007 16:10:02 Robert Marella wrote: > > On Thu, 24 May 2007 15:48:04 -0300 > > > > > > Hi > > > so you are suggesting a rollback? I compiled on may 21st and 23rd > > > and as Joe Altman confirmed too it's not working anymore on > > > amd64 ... on i386 it's ok, may be this is a good moment then to > > > change my backup strategy and use usb mem chips and kick atapicam > > > out of the kernel > > > > Well, now I'm scared! I usually update via build kernel/world on > > Fridays but I missed a week or two. I was planing on doing it > > tomorrow. > > > > I don't think I'll have a need for K3B so for test purposes I will > > do it today and report back in an hour or so. > > > > Wish me luck. > > > > my dear ... no luck in site at this moment, don't wast your time, > patience is what you need now and a tail -f on cvs-src ;) > > > Please forgive an old man's failing memory. I have two systems running 6 stable. One is i386 and the other amd64. Back in April a patch was made available for the K3B problem. It fixed both of the systems. I updated the i386 on May 4th and the patch was no longer needed but I never updated the amd64 so it is running K3B with the patch. I am in the process of updating the amd64 and will test it without and with the patch. I have attached the patch in case you never saw it. Robert --MP_2xhkw9d8IeG+6yR0/0r5ylz Content-Type: text/x-patch; name=atampicam.diff Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=atampicam.diff RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v retrieving revision 1.50 diff -u -r1.50 atapi-cam.c --- atapi-cam.c 14 Mar 2007 01:59:00 -0000 1.50 +++ atapi-cam.c 27 Apr 2007 19:26:09 -0000 @@ -729,7 +743,7 @@ * issued a REQUEST SENSE automatically and that operation * returned without error. */ - if (request->u.atapi.saved_cmd != 0 && request->error == 0) { + if (request->u.atapi.sense.key != 0 && request->error == 0) { bcopy (&request->u.atapi.sense, &csio->sense_data, sizeof(struct atapi_sense)); csio->ccb_h.status |= CAM_AUTOSNS_VALID; } --MP_2xhkw9d8IeG+6yR0/0r5ylz--