Date: Thu, 22 Nov 2007 12:42:03 +0100 From: "Attilio Rao" <attilio@freebsd.org> To: "Alfred Perlstein" <alfred@freebsd.org> Cc: arch@freebsd.org Subject: Re: rwlocks, correctness over speed. Message-ID: <3bbf2fe10711220342i3360f077u2e093a676b1fdbe8@mail.gmail.com> In-Reply-To: <20071121222319.GX44563@elvis.mu.org> References: <20071121222319.GX44563@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2007/11/21, Alfred Perlstein <alfred@freebsd.org>: > In summary, I am proposing (temporarily) making read-recursion > on rwlocks not supported in order to avoid livelock due to writer > starvation. > > More details: > > We currently have a problem with our implementation of rwlocks. > > I think this is a key issue for 7.x as what we decide to support > will have rammifications for many years to come. > > We do not support writer priority or "fair share" usage of rwlocks > between readers and writers. > > We have several choices to rectify this. > > 1. Disallow recursion on rwlocks (witness can be used to enforce this), > this simplifies rwlocks such that we can avoid deadlock when a single > reader is trying to recurse while a writer is pending. > > 2. Track ownership of rwlocks, this can be implemented with a "rwlock > stack" in the per-thread control block (struct thread). Using this > ownership information we can determine if someone is recursing and > allow them to continue recursing despite a pending write request. > > I think the most simple solution currently is to drop support for > recursive reads on rwlocks until we have the facility in place > to properly support starvation avoidance. > > Why is this important? > > Simply put, developers that quickly "fix" some portion of code, > whether that be a driver or part of the kernel proper who use read > recursion will open the system to writer starvation and hence the > system will destabilize, particulary for high load situations. > > I would like to get this in before 7.0-RELEASE becasue otherwise > we're forced to implement something like the above mentioned solution > #2, which will degrade performance for most use cases of rwlocks. As we alredy discussed on IRC, I'm for assuming no recursion on readers (recursion on writers doesn't play any role here, so it is ok maintaining the current behaviour) and adding a mechanism to WITNESS in order to catch cases where such condition is violated. In this way we don't penalyze fast cases. Do you alredy have a patch for the wakeup / sleeping algorithm? Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10711220342i3360f077u2e093a676b1fdbe8>